Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exit code handling #210

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Fix exit code handling #210

merged 1 commit into from
Jun 23, 2020

Conversation

lcobucci
Copy link
Member

The exit code was only being checked on PHP 7.4+, which is completely wrong.

This makes the checks behave consistently across all supported versions, updating the expected reports accordingly.

Fixes: #209

@lcobucci
Fix exit code handling
96275cb 
The exit code was only being checked on PHP 7.4+, which is completely
wrong.

This makes the checks behave consistently across all supported versions,
updating the expected reports accordingly.
@lcobucci lcobucci requested a review from a team June 22, 2020 20:21
@lcobucci lcobucci self-assigned this Jun 22, 2020
@lcobucci lcobucci mentioned this pull request Jun 22, 2020
Closed
@gmponos
Copy link
Contributor

gmponos commented Jun 22, 2020 •
edited
Loading

Hi!.. sorry to be a PITA.. but maybe it's best if you could split this into two commits.. the first one to fail and the second to fix the report and be green?

Because now how can we be sure that this is even fixed?

@lcobucci
Copy link
Member Author

Hi!.. sorry to be a PITA.. but maybe it's best if you could split this into two commits.. the first one to fail and the second to fix the report and be green?

That wouldn't be an atomic commit, so I rather not do that. Other maintainers are free to rebase and rework my stuff.

Because now how can we be sure that this is even fixed?

You can look at the output of the job and see that there's no diff being reported. If you want, you can even play locally with the things to ensure the problem is addressed.

@gmponos
Copy link
Contributor

gmponos commented Jun 22, 2020

ok ok.. no problem 👍

gmponos
gmponos approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@gmponos gmponos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

carusogabriel
carusogabriel approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@carusogabriel carusogabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lcobucci Thanks for taking a look into this!

@greg0ire greg0ire merged commit 03ec064 into doctrine:master Jun 23, 2020
@greg0ire
Copy link
Member

Thanks @lcobucci !

@greg0ire
Copy link
Member

Hi!.. sorry to be a PITA.. but maybe it's best if you could split this into two commits.. the first one to fail and the second to fix the report and be green?

I would have the opposite order actually :P and pushed an extra commit to do the check ^^

@greg0ire greg0ire added this to the 8.2.0 milestone Oct 25, 2020
@github-actions github-actions bot mentioned this pull request Oct 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carusogabriel carusogabriel carusogabriel approved these changes

@gmponos gmponos gmponos approved these changes

@SenseException SenseException SenseException approved these changes

@ostrolucky ostrolucky ostrolucky approved these changes

Assignees

@lcobucci lcobucci

Labels
bug CI
Projects
None yet
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.

The php72 test-report job is always successful
6 participants
@lcobucci @gmponos @greg0ire @ostrolucky @SenseException @carusogabriel