-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer: update PHPCS Composer plugin dependency #213
Composer: update PHPCS Composer plugin dependency #213
Conversation
The DealerDirect Composer plugin has just released version `0.7.0`. As Composer treats minors < 1.0 as majors, updating to this version requires an update to the `composer.json` requirements. > For pre-1.0 versions it also acts with safety in mind and treats `^0.3` as `>=0.3.0 <0.4.0`. Note: This standard can be combined by end-users with other PHPCS standards which may also include the Dealerdirect Composer plugin. Also: projects which _require_ this standard, may also require the plugin directly. With that in mind, it is strongly recommended to allow a wider range or versions to prevent conflicts, as per this PR. Refs: * https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases/tag/v0.7.0 * https://getcomposer.org/doc/articles/versions.md#caret-version-range-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes: #214
@doctrine/team-coding-standards any more reviews, please? This seems to be a blocker for being able to use Composer 2 with all Doctrine projects. |
Thanks @jrfnl ! |
What milestone should we affect this to? |
You're welcome. |
@beberlei @morozov I was going to release this as an 8.1.0, as per our discussion, and had a look at commits to master since the last release, and found this PR that was added to milestone 9.0.0 : #199 … what now? This repo seems to have a workflow that is different from other repos… reassigning to 9.0.0 for now since that's the least broken state. |
What if you fork |
I was a bit unsure of how the release tool would behave, but looking at the Behat scenario, it shouldn't care where this was merged, and instead just look at the milestone and existing branches. Let's try… I'm also cherry-picking pedantic changes (which don't have a milestone), to minimize branch divergence and ensure the CI works properly on 8.1.x |
Released as 8.1.0 |
The DealerDirect Composer plugin has just released version
0.7.0
.This new version includes support for Composer 2.0.0 (upcoming) and allows for installation of the plugin in combination with PHP 8 and PHPCS 4.x-dev (for testing).
As Composer treats minors < 1.0 as majors, updating to this version requires an update to the
composer.json
requirements.Note:
This standard can be combined by end-users with other PHPCS standards which may also include the Dealerdirect Composer plugin. Also: projects which require this standard, may also require the plugin directly.
With that in mind, it is strongly recommended to allow a wider range or versions to prevent conflicts, as per this PR.
Refs:
Closes #212