Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer: update PHPCS Composer plugin dependency #213

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Jun 30, 2020

The DealerDirect Composer plugin has just released version 0.7.0.
This new version includes support for Composer 2.0.0 (upcoming) and allows for installation of the plugin in combination with PHP 8 and PHPCS 4.x-dev (for testing).

As Composer treats minors < 1.0 as majors, updating to this version requires an update to the composer.json requirements.

For pre-1.0 versions it also acts with safety in mind and treats ^0.3 as >=0.3.0 <0.4.0.

Note:
This standard can be combined by end-users with other PHPCS standards which may also include the Dealerdirect Composer plugin. Also: projects which require this standard, may also require the plugin directly.
With that in mind, it is strongly recommended to allow a wider range or versions to prevent conflicts, as per this PR.

Refs:

Closes #212

The DealerDirect Composer plugin has just released version `0.7.0`.

As Composer treats minors < 1.0 as majors, updating to this version requires an update to the `composer.json` requirements.

> For pre-1.0 versions it also acts with safety in mind and treats `^0.3` as `>=0.3.0 <0.4.0`.

Note:
This standard can be combined by end-users with other PHPCS standards which may also include the Dealerdirect Composer plugin. Also: projects which _require_ this standard, may also require the plugin directly.
With that in mind, it is strongly recommended to allow a wider range or versions to prevent conflicts, as per this PR.

Refs:
* https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases/tag/v0.7.0
* https://getcomposer.org/doc/articles/versions.md#caret-version-range-
@greg0ire greg0ire requested a review from a team June 30, 2020 11:20
Copy link

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes: #214

@morozov
Copy link
Member

morozov commented Jul 1, 2020

@doctrine/team-coding-standards any more reviews, please? This seems to be a blocker for being able to use Composer 2 with all Doctrine projects.

@greg0ire greg0ire requested a review from a team July 1, 2020 19:36
@greg0ire greg0ire merged commit d2cd712 into doctrine:master Jul 1, 2020
@greg0ire
Copy link
Member

greg0ire commented Jul 1, 2020

Thanks @jrfnl !

@greg0ire
Copy link
Member

greg0ire commented Jul 1, 2020

What milestone should we affect this to?

@greg0ire greg0ire self-assigned this Jul 1, 2020
@jrfnl jrfnl deleted the feature/composer-allow-for-new-composer-plugin-version branch July 1, 2020 19:43
@jrfnl
Copy link
Contributor Author

jrfnl commented Jul 1, 2020

You're welcome.

@greg0ire greg0ire added this to the 8.1.0 milestone Jul 5, 2020
@greg0ire
Copy link
Member

greg0ire commented Jul 5, 2020

@beberlei @morozov I was going to release this as an 8.1.0, as per our discussion, and had a look at commits to master since the last release, and found this PR that was added to milestone 9.0.0 : #199 … what now? This repo seems to have a workflow that is different from other repos… reassigning to 9.0.0 for now since that's the least broken state.

@greg0ire greg0ire modified the milestones: 8.1.0, 9.0.0 Jul 5, 2020
@morozov
Copy link
Member

morozov commented Jul 5, 2020

What if you fork 8.1 from the point before the breaking changes, backport this change there and release? The rest will have to wait until 9.0.0.

@greg0ire greg0ire modified the milestones: 9.0.0, 8.1.0 Jul 5, 2020
@greg0ire
Copy link
Member

greg0ire commented Jul 5, 2020

I was a bit unsure of how the release tool would behave, but looking at the Behat scenario, it shouldn't care where this was merged, and instead just look at the milestone and existing branches. Let's try… I'm also cherry-picking pedantic changes (which don't have a milestone), to minimize branch divergence and ensure the CI works properly on 8.1.x

@greg0ire
Copy link
Member

greg0ire commented Jul 5, 2020

Released as 8.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants