Add tests for PHP 8 #257
Merged
Add tests for PHP 8 #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Jul 20, 2021
morozov
approved these changes
Jul 20, 2021
ostrolucky
approved these changes
Jul 20, 2021
|
Thanks @simPod ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried applying patches over themselves (e.g. apply 7.4 patch and then 8.0 patch over that 7.4 patch) but maintainability of that approach sucks. It's better to have a full patch for concrete version. It's easier to apply and reverse one patch instead of multiple ones and also single patch works well with
update-compatibility-patchmake target.