Case insensitive like #123
Open
+41
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
Jul 12, 2017
lib/Doctrine/Common/Collections/Expr/ClosureExpressionVisitor.php
Outdated
Show resolved
Hide resolved
- fixed closure
Majkl578
reviewed
Jul 15, 2017
| @@ -173,6 +173,11 @@ public function walkComparison(Comparison $comparison) | |||
| return false !== strpos(ClosureExpressionVisitor::getObjectFieldValue($object, $field), $value); | |||
| }; | |||
|
|
|||
| case Comparison::ICONTAINS: | |||
| return function ($object) use ($field, $value) { | |||
| return false !== strpos(mb_strtolower(ClosureExpressionVisitor::getObjectFieldValue($object, $field)), mb_strtolower($value)); | |||
There was a problem hiding this comment.
Hmm, although it's correct, using mb_strtolower introduces dependency on ext-mbstring, which is not bundled in PHP. It's not hard dependency (required only when ICONTAINS is used), but it should probably be added to suggest section in the composer.json.
|
@Ocramius I'm waiting for this feature as well, what's the current state? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Comparison::ICONTAINS to create a case insensitive like.
Depends on doctrine PR#6547