Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate all symbols in the Doctrine\Common\Proxy namespace #1002

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

nicolas-grekas
Copy link
Member

Allowed by doctrine/orm#10837

@nicolas-grekas nicolas-grekas force-pushed the deprec-proxy branch 2 times, most recently from fc37b47 to eea8e56 Compare July 13, 2023 09:00
@derrabus
Copy link
Member

Do we actually plan to release a v4 without Proxies? If the ORM does not use common proxies anymore, we'd simply drop the dependency.

@nicolas-grekas
Copy link
Member Author

Do we actually plan to release a v4 without Proxies?

This would cut the maintenance yes. Proxies are hard to maintain, especially in the form they take in this repo (see PRs related to readonly or enums for examples.)

@derrabus
Copy link
Member

I understand that, but what remains of this library if we remove proxies is not worth maintaining imho. I think, we can simply archive the repo once the ORM doesn't use it anymore.

@nicolas-grekas
Copy link
Member Author

It'd still be great to release a version with deprecations, so that ppl that rely on eg instanceof Common\Proxy\Proxy can know they should move on.

@derrabus
Copy link
Member

Okay, how about:

  • Annotate all classes and interfaces with @deprecated, not just the Proxy stuff
  • Remove all mentions of version 4.0
  • No runtime deprecation warnings as there is no urge to resolve them.
  • A note in the README about our plans of sunsetting this library

@nicolas-grekas nicolas-grekas force-pushed the deprec-proxy branch 2 times, most recently from 1646deb to d2ed793 Compare July 31, 2023 11:14
@nicolas-grekas
Copy link
Member Author

Remove all mentions of version 4.0
No runtime deprecation warnings as there is no urge to resolve them.

Done for those

For the rest, that's a separate effort to me.

derrabus
derrabus previously approved these changes Jul 31, 2023
src/Proxy/Autoloader.php Outdated Show resolved Hide resolved
@derrabus derrabus merged commit c1e3356 into 3.5.x Aug 10, 2023
14 checks passed
@derrabus derrabus deleted the deprec-proxy branch August 10, 2023 07:28
@derrabus derrabus added this to the 3.5.0 milestone Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants