Separate Event Manager to doctrine/event-manager #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Jun 7, 2018
composer.json
Outdated
| @@ -19,7 +19,8 @@ | |||
| "doctrine/cache": "1.*", | |||
| "doctrine/collections": "1.*", | |||
| "doctrine/lexer": "1.*", | |||
| "doctrine/annotations": "1.*" | |||
| "doctrine/annotations": "1.*", | |||
| "doctrine/event-manager": "1.*@dev" | |||
There was a problem hiding this comment.
^1.0.0@dev (without @dev once we release it)?
There was a problem hiding this comment.
I replaced all constraints with caret. 👍
jwage
approved these changes
Jun 11, 2018
Ocramius
approved these changes
Jun 11, 2018
|
🚂 |
This was referenced Jun 15, 2018
symfony-splitter
pushed a commit
to symfony/doctrine-bridge
that referenced
this pull request
Jun 20, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- Remove direct dependencies on doctrine/common | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | ? Doctrine has recently separated multiple components from doctrine/common: * [doctrine/event-manager](https://github.com/doctrine/event-manager) [[release notes](https://github.com/doctrine/event-manager/releases/tag/v1.0.0) | [split PR](doctrine/common#842)] * [doctrine/persistence](https://github.com/doctrine/persistence) [[release notes](https://github.com/doctrine/persistence/releases/tag/v1.0.0) | [split PR](doctrine/common#845)] * [doctrine/reflection](https://github.com/doctrine/reflection) [[release notes](https://github.com/doctrine/reflection/releases/tag/v1.0.0) | [split PR](doctrine/common#845)] All of the packages are 100% backward compatible with their counterparts in Common 2.8. This is a major step to slowly start with [phasing out doctrine/common package](doctrine/common#826) before ORM 3.0 / DBAL 3.0 / ODM 3.0. Common 2.9.0 will also be composed from these new packages. Most of the remaining parts in doctrine/common are likely to be deprecated (or already are), please see & discuss in [the PR over in doctrine/common repository](doctrine/common#845). This PR therefore aims to remove the direct doctrine/common dependency from Symfony, replacing it by specific Doctrine components. Commits ------- b0fa398187 Remove direct dependencies on doctrine/common
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jun 20, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- Remove direct dependencies on doctrine/common | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | ? Doctrine has recently separated multiple components from doctrine/common: * [doctrine/event-manager](https://github.com/doctrine/event-manager) [[release notes](https://github.com/doctrine/event-manager/releases/tag/v1.0.0) | [split PR](doctrine/common#842)] * [doctrine/persistence](https://github.com/doctrine/persistence) [[release notes](https://github.com/doctrine/persistence/releases/tag/v1.0.0) | [split PR](doctrine/common#845)] * [doctrine/reflection](https://github.com/doctrine/reflection) [[release notes](https://github.com/doctrine/reflection/releases/tag/v1.0.0) | [split PR](doctrine/common#845)] All of the packages are 100% backward compatible with their counterparts in Common 2.8. This is a major step to slowly start with [phasing out doctrine/common package](doctrine/common#826) before ORM 3.0 / DBAL 3.0 / ODM 3.0. Common 2.9.0 will also be composed from these new packages. Most of the remaining parts in doctrine/common are likely to be deprecated (or already are), please see & discuss in [the PR over in doctrine/common repository](doctrine/common#845). This PR therefore aims to remove the direct doctrine/common dependency from Symfony, replacing it by specific Doctrine components. Commits ------- b0fa398 Remove direct dependencies on doctrine/common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventManager + EventSubscriber + EventArgs separated into doctrine/event-manager.
One step closer to finishing #826.
Note:
@devneeds to be removed before 2.9.0 (once1.0.0is tagged).