Handle readonly public properties, cf. #954 #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the handling of readonly public properties by unsetting them and thus making them available for intercept by the magic methods. Cloning, serialization and deserialization are handled accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix #954
This fixes the handling of readonly public properties by unsetting them and thus making them available for intercept by the magic methods. Cloning, serialization and deserialization are handled accordingly.
When instantiating a proxy object, the readonly properties are unset from the scope of the proxy parent class, allowing them to be initialized by the proxy factory and, later, the persister.
This paves the way to allow lazy loading in the presence of readonly public properties.
To fully support readonly public properties, the ProxyFactory cloner implementation and the UnitOfWork createEntity method must account for them, avoiding repeat initializations.