Relax type of identifiers #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ORM and ODM and other things having an implementation of ReferenceRepository do not necessarily agree on what an identifier should be. data-fixtures should not really care either so long as the identifier can be used with serialize(). Let us relax the type of identifers to mixed.
|
But doesn't |
|
It does, but I don't think there is a Since |
SenseException
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Since serialize() accepts mixed, I guess mixed is the best we can do here.
This is probably the same relict as php functions returning false in case of an error and was transferred to newer PHP versions for compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ORM and ODM and other things having an implementation of ReferenceRepository do not necessarily agree on what an identifier should be.
data-fixtures should not really care either so long as the identifier can be used with serialize().
Let us relax the type of identifers to mixed.