-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bugfix: deallocate mysqli prepared statement
Long running processes might hit the `max_prepared_stmt_count` due not deallocating the statement correctly.
- Loading branch information
Showing
3 changed files
with
78 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace Doctrine\DBAL\Tests\Functional\Driver\Mysqli; | ||
|
||
use Doctrine\DBAL\Driver\Mysqli\Statement; | ||
use Doctrine\DBAL\Statement as WrapperStatement; | ||
use Doctrine\DBAL\Tests\FunctionalTestCase; | ||
use Doctrine\DBAL\Tests\TestUtil; | ||
use Error; | ||
use ReflectionProperty; | ||
|
||
use const PHP_VERSION_ID; | ||
|
||
/** @requires extension mysqli */ | ||
class StatementTest extends FunctionalTestCase | ||
{ | ||
protected function setUp(): void | ||
{ | ||
parent::setUp(); | ||
|
||
if (TestUtil::isDriverOneOf('mysqli')) { | ||
return; | ||
} | ||
|
||
self::markTestSkipped('This test requires the mysqli driver.'); | ||
} | ||
|
||
public function testStatementsAreDeallocatedProperly(): void | ||
{ | ||
$statement = $this->connection->prepare('SELECT 1'); | ||
|
||
$property = new ReflectionProperty(WrapperStatement::class, 'stmt'); | ||
$property->setAccessible(true); | ||
|
||
$driverStatement = $property->getValue($statement); | ||
|
||
$mysqliProperty = new ReflectionProperty(Statement::class, 'stmt'); | ||
$mysqliProperty->setAccessible(true); | ||
|
||
$mysqliStatement = $mysqliProperty->getValue($driverStatement); | ||
|
||
unset($statement, $driverStatement); | ||
|
||
|
||
if (PHP_VERSION_ID < 80000) { | ||
$this->expectError(); | ||
$this->expectErrorMessage('mysqli_stmt::execute(): Couldn\'t fetch mysqli_stmt'); | ||
} else { | ||
$this->expectException(Error::class); | ||
$this->expectExceptionMessage('mysqli_stmt object is already closed'); | ||
} | ||
|
||
$mysqliStatement->execute(); | ||
} | ||
} |