Deprecate Doctrine\DBAL\Types\Type::getDefaultLength()

doctrine · Aug 17, 2018 · 38e0e91 · 38e0e91
1 parent 319e20f
commit 38e0e91
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -1,5 +1,9 @@
 # Upgrade to 2.9
 
+## Deprecated `Doctrine\DBAL\Types\Type::getDefaultLength()`
+
+This method was never used by DBAL internally. It is now deprecated.
+
 ## Deprecated `NULL` value of `$offset` in LIMIT queries
 
 The `NULL` value of the `$offset` argument in `AbstractPlatform::(do)?ModifyLimitQuery()` methods is deprecated. If explicitly used in the method call, the absence of the offset should be indicated with a `0`.

diff --git a/lib/Doctrine/DBAL/Types/Type.php b/lib/Doctrine/DBAL/Types/Type.php
@@ -146,7 +146,7 @@ public function convertToPHPValue($value, AbstractPlatform $platform)
      *
      * @return int|null
      *
-     * @todo Needed?
+     * @deprecated Rely on information provided by the platform instead.
      */
     public function getDefaultLength(AbstractPlatform $platform)
     {