Do not normalize current version during comparison

doctrine · Sep 12, 2021 · 41cb3ed · 41cb3ed
1 parent f1a05f8
commit 41cb3ed
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 13 deletions.
diff --git a/lib/Doctrine/DBAL/Version.php b/lib/Doctrine/DBAL/Version.php
@@ -3,7 +3,7 @@
 namespace Doctrine\DBAL;
 
 use function str_replace;
-use function strtolower;
+use function strtoupper;
 use function version_compare;
 
 /**
@@ -28,9 +28,8 @@ class Version
      */
     public static function compare($version)
     {
-        $currentVersion = str_replace(' ', '', strtolower(self::VERSION));
-        $version        = str_replace(' ', '', $version);
+        $version = str_replace(' ', '', strtoupper($version));
 
-        return version_compare($version, $currentVersion);
+        return version_compare($version, self::VERSION);
     }
 }
diff --git a/psalm.xml.dist b/psalm.xml.dist
@@ -311,15 +311,6 @@
                 <directory name="lib"/>
             </errorLevel>
         </RedundantCastGivenDocblockType>
-        <RedundantCondition>
-            <errorLevel type="suppress">
-                <!--
-                    This suppression should be removed in 3.0.x
-                    See https://github.com/doctrine/dbal/pull/3860
-                -->
-                <file name="lib/Doctrine/DBAL/Version.php"/>
-            </errorLevel>
-        </RedundantCondition>
         <RedundantConditionGivenDocblockType>
             <errorLevel type="suppress">
                 <!--