Failing test to identify string literal quoting issues

doctrine · Oct 24, 2018 · 55b409b · 55b409b
1 parent 1b1adc2
commit 55b409b
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 20 deletions.
diff --git a/lib/Doctrine/DBAL/Platforms/OraclePlatform.php b/lib/Doctrine/DBAL/Platforms/OraclePlatform.php
@@ -1175,14 +1175,4 @@ public function getBlobTypeDeclarationSQL(array $field)
     {
         return 'BLOB';
     }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function quoteStringLiteral($str)
-    {
-        $str = str_replace('\\', '\\\\', $str); // Oracle requires backslashes to be escaped aswell.
-
-        return parent::quoteStringLiteral($str);
-    }
 }
diff --git a/lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php b/lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php
@@ -1199,16 +1199,6 @@ public function getBlobTypeDeclarationSQL(array $field)
         return 'BYTEA';
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    public function quoteStringLiteral($str)
-    {
-        $str = str_replace('\\', '\\\\', $str); // PostgreSQL requires backslashes to be escaped aswell.
-
-        return parent::quoteStringLiteral($str);
-    }
-
     /**
      * {@inheritdoc}
      */

diff --git a/tests/Doctrine/Tests/DBAL/Functional/Platform/QuotingTest.php b/tests/Doctrine/Tests/DBAL/Functional/Platform/QuotingTest.php
@@ -0,0 +1,32 @@
+<?php
+
+namespace Doctrine\Tests\DBAL\Functional\Platform;
+
+use Doctrine\Tests\DbalFunctionalTestCase;
+
+class QuotingTest extends DbalFunctionalTestCase
+{
+    /**
+     * @dataProvider stringLiteralProvider
+     */
+    public function testQuoteStringLiteral(string $string) : void
+    {
+        $platform = $this->connection->getDatabasePlatform();
+        $query    = $platform->getDummySelectSQL(
+            $platform->quoteStringLiteral($string)
+        );
+
+        self::assertSame($string, $this->connection->fetchColumn($query));
+    }
+
+    /**
+     * @return mixed[][]
+     */
+    public static function stringLiteralProvider() : iterable
+    {
+        return [
+            'backslash' => ['\\'],
+            'single-quote' => ["'"],
+        ];
+    }
+}