Merge pull request #4134 from morozov/deprecate-some-dbal-exception-m…

…ethods Deprecate some DBALException factory methods
doctrine · Jul 2, 2020 · 8e4b2b2 · 8e4b2b2
2 parents 28ac296 + 0fe1dc4
commit 8e4b2b2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -1,5 +1,10 @@
 # Upgrade to 2.11
 
+## `DBALException` factory method deprecations
+
+1. `DBALException::invalidPlatformType()` is deprecated as unused as of v2.7.0.
+2. `DBALException::invalidPdoInstance()` as passing a PDO instance via configuration is deprecated.
+
 ## `AbstractPlatform::fixSchemaElementName()` is deprecated.
 
 The method is not used anywhere except for tests.

diff --git a/lib/Doctrine/DBAL/DBALException.php b/lib/Doctrine/DBAL/DBALException.php
@@ -38,6 +38,9 @@ public static function notSupported($method)
         return new self(sprintf("Operation '%s' is not supported by platform.", $method));
     }
 
+    /**
+     * @deprecated Use {@link invalidPlatformType()} instead.
+     */
     public static function invalidPlatformSpecified(): self
     {
         return new self(
@@ -90,6 +93,8 @@ public static function invalidPlatformVersionSpecified($version, $expectedFormat
     }
 
     /**
+     * @deprecated Passing a PDO instance in connection parameters is deprecated.
+     *
      * @return DBALException
      */
     public static function invalidPdoInstance()