Remove pdo_sqlsrv from known vendor issues list

doctrine · Nov 17, 2018 · 93aaa1b · 93aaa1b
1 parent ce45348
commit 93aaa1b
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 17 deletions.
diff --git a/docs/en/reference/configuration.rst b/docs/en/reference/configuration.rst
@@ -139,7 +139,6 @@ interfaces to use. It can be configured in one of three ways:
       extension.
       **Note that this driver caused problems in our tests. Prefer the oci8 driver if possible.**
    -  ``pdo_sqlsrv``: A Microsoft SQL Server driver that uses pdo\_sqlsrv PDO
-      **Note that this driver caused problems in our tests. Prefer the sqlsrv driver if possible.**
    -  ``sqlsrv``: A Microsoft SQL Server driver that uses the sqlsrv PHP extension.
    -  ``oci8``: An Oracle driver that uses the oci8 PHP extension.
    -  ``sqlanywhere``: A SAP Sybase SQL Anywhere driver that uses the sqlanywhere PHP extension.

diff --git a/docs/en/reference/known-vendor-issues.rst b/docs/en/reference/known-vendor-issues.rst
@@ -179,14 +179,3 @@ liberal DateTime parser that detects the format automatically:
     Type::overrideType('datetime_immutable', 'Doctrine\DBAL\Types\VarDateTimeImmutableType');
     Type::overrideType('datetimetz_immutable', 'Doctrine\DBAL\Types\VarDateTimeImmutableType');
     Type::overrideType('time_immutable', 'Doctrine\DBAL\Types\VarDateTimeImmutableType');
-
-PDO_SQLSRV: VARBINARY/BLOB columns
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-
-The ``PDO_SQLSRV`` driver currently has a bug when binding values to
-VARBINARY/BLOB columns with ``bindValue`` in prepared statements.
-This raises an implicit conversion from data type error as it tries
-to convert a character type value to a binary type value even if
-you explicitly define the value as ``ParameterType::LARGE_OBJECT`` type.
-Therefore it is highly encouraged to use the native ``sqlsrv``
-driver instead which does not have this limitation.
diff --git a/tests/Doctrine/Tests/DBAL/Functional/BlobTest.php b/tests/Doctrine/Tests/DBAL/Functional/BlobTest.php
@@ -3,7 +3,6 @@
 namespace Doctrine\Tests\DBAL\Functional;
 
 use Doctrine\DBAL\Driver\OCI8\Driver as OCI8Driver;
-use Doctrine\DBAL\Driver\PDOSqlsrv\Driver as PDOSQLSrvDriver;
 use Doctrine\DBAL\FetchMode;
 use Doctrine\DBAL\ParameterType;
 use Doctrine\DBAL\Schema\AbstractSchemaManager;
@@ -23,10 +22,6 @@ protected function setUp()
     {
         parent::setUp();
 
-        if ($this->connection->getDriver() instanceof PDOSQLSrvDriver) {
-            $this->markTestSkipped('This test does not work on pdo_sqlsrv driver due to a bug. See: http://social.msdn.microsoft.com/Forums/sqlserver/en-US/5a755bdd-41e9-45cb-9166-c9da4475bb94/how-to-set-null-for-varbinarymax-using-bindvalue-using-pdosqlsrv?forum=sqldriverforphp');
-        }
-
         /** @var AbstractSchemaManager $sm */
         $table = new Table('blob_table');
         $table->addColumn('id', 'integer');