Merge pull request #3955 from greg0ire/smaller-baseline

Remove baseline
doctrine · Apr 16, 2020 · 95ab020 · 95ab020
2 parents 72d9081 + bbf31dc
commit 95ab020
Show file tree

Hide file tree

Showing 15 changed files with 62 additions and 224 deletions.
diff --git a/baseline.xml b/baseline.xml
diff --git a/composer.json b/composer.json
@@ -40,6 +40,7 @@
  "require-dev": {
  "doctrine/coding-standard": "^6.0",
  "jetbrains/phpstorm-stubs": "^2019.1",
+ "nikic/php-parser": "^4.4",
  "phpstan/phpstan": "^0.12",
  "phpunit/phpunit": "^8.4.1",
  "symfony/console": "^2.0.5|^3.0|^4.0|^5.0",

diff --git a/composer.lock b/composer.lock
diff --git a/lib/Doctrine/DBAL/Connection.php b/lib/Doctrine/DBAL/Connection.php
@@ -823,7 +823,7 @@ public function quoteIdentifier($str)
  /**
  * {@inheritDoc}
  */
- public function quote($input, $type = null)
+ public function quote($input, $type = ParameterType::STRING)
  {
  $connection = $this->getWrappedConnection();
 

diff --git a/lib/Doctrine/DBAL/Driver/AbstractDriverException.php b/lib/Doctrine/DBAL/Driver/AbstractDriverException.php
@@ -6,6 +6,8 @@
 
 /**
  * Abstract base implementation of the {@link DriverException} interface.
+ *
+ * @psalm-immutable
  */
 abstract class AbstractDriverException extends Exception implements DriverException
 {

diff --git a/lib/Doctrine/DBAL/Driver/DriverException.php b/lib/Doctrine/DBAL/Driver/DriverException.php
@@ -9,6 +9,8 @@
  *
  * Driver exceptions provide the SQLSTATE of the driver
  * and the driver specific error code at the time the error occurred.
+ *
+ * @psalm-immutable
  */
 interface DriverException extends Throwable
 {

diff --git a/lib/Doctrine/DBAL/Driver/Mysqli/MysqliException.php b/lib/Doctrine/DBAL/Driver/Mysqli/MysqliException.php
@@ -6,6 +6,8 @@
 
 /**
  * Exception thrown in case the mysqli driver errors.
+ *
+ * @psalm-immutable
  */
 class MysqliException extends AbstractDriverException
 {

diff --git a/lib/Doctrine/DBAL/Driver/OCI8/OCI8Exception.php b/lib/Doctrine/DBAL/Driver/OCI8/OCI8Exception.php
@@ -4,6 +4,9 @@
 
 use Doctrine\DBAL\Driver\AbstractDriverException;
 
+/**
+ * @psalm-immutable
+ */
 class OCI8Exception extends AbstractDriverException
 {
  /**

diff --git a/lib/Doctrine/DBAL/Driver/PDOException.php b/lib/Doctrine/DBAL/Driver/PDOException.php
@@ -4,6 +4,8 @@
 
 /**
  * Tiny wrapper for PDOException instances to implement the {@link DriverException} interface.
+ *
+ * @psalm-immutable
  */
 class PDOException extends \PDOException implements DriverException
 {

diff --git a/lib/Doctrine/DBAL/Driver/SQLAnywhere/SQLAnywhereException.php b/lib/Doctrine/DBAL/Driver/SQLAnywhere/SQLAnywhereException.php
@@ -12,6 +12,8 @@
 
 /**
  * SAP Sybase SQL Anywhere driver exception.
+ *
+ * @psalm-immutable
  */
 class SQLAnywhereException extends AbstractDriverException
 {

diff --git a/lib/Doctrine/DBAL/Driver/SQLSrv/SQLSrvException.php b/lib/Doctrine/DBAL/Driver/SQLSrv/SQLSrvException.php
@@ -7,6 +7,9 @@
 use function rtrim;
 use function sqlsrv_errors;
 
+/**
+ * @psalm-immutable
+ */
 class SQLSrvException extends AbstractDriverException
 {
  /**

diff --git a/lib/Doctrine/DBAL/Platforms/SqlitePlatform.php b/lib/Doctrine/DBAL/Platforms/SqlitePlatform.php
@@ -807,6 +807,8 @@ public function getCreateConstraintSQL(Constraint $constraint, $table)
 
  /**
  * {@inheritDoc}
+ *
+ * @param int|null $createFlags
  */
  public function getCreateTableSQL(Table $table, $createFlags = null)
  {

diff --git a/lib/Doctrine/DBAL/Schema/OracleSchemaManager.php b/lib/Doctrine/DBAL/Schema/OracleSchemaManager.php
@@ -287,6 +287,8 @@ protected function _getPortableDatabaseDefinition($database)
  /**
  * {@inheritdoc}
  *
+ * @param string|null $database
+ *
  * Calling this method without an argument or by passing NULL is deprecated.
  */
  public function createDatabase($database = null)