Use $maxLength = 0 by default when calling PDOStatement::bindParam()

doctrine · Dec 28, 2021 · bf72469 · bf72469
1 parent b4f49c0
commit bf72469
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/Driver/PDO/Statement.php b/src/Driver/PDO/Statement.php
@@ -80,7 +80,13 @@ public function bindParam(
         $type = $this->convertParamType($type);
 
         try {
-            return $this->stmt->bindParam($param, $variable, $type, ...array_slice(func_get_args(), 3));
+            return $this->stmt->bindParam(
+                $param,
+                $variable,
+                $type,
+                $length ?? 0,
+                ...array_slice(func_get_args(), 4)
+            );
         } catch (PDOException $exception) {
             throw Exception::new($exception);
         }

diff --git a/tests/Functional/StatementTest.php b/tests/Functional/StatementTest.php
@@ -224,6 +224,18 @@ public function testReuseStatementWithReboundParam(): void
         self::assertEquals(2, $result->fetchOne());
     }
 
+    public function testBindParamWithNullLength(): void
+    {
+        $this->connection->insert('stmt_test', ['id' => 1]);
+
+        $stmt = $this->connection->prepare('SELECT id FROM stmt_test WHERE id = ?');
+
+        $value = 1;
+        $stmt->bindParam(1, $value, ParameterType::INTEGER, null);
+
+        self::assertEquals(1, $stmt->executeQuery()->fetchOne());
+    }
+
     /**
      * @param mixed $expected
      *