Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBAL-1082: SchemaTool does not generate DDL for MySQL unsigned float #1018

Closed
doctrinebot opened this issue Dec 18, 2014 · 4 comments
Closed

Comments

@doctrinebot
Copy link

Jira issue originally created by user dchesterton:

The schema update tool does not consider the possibility that MySQL double/float fields can be unsigned.

When running the CLI tool, it recognises that the schemas differ but it doesn't add the appropriate 'UNSIGNED' SQL statement. For example when the database is SIGNED but the entity is marked as UNSIGNED, running the tool with --dump-sql will generate SQL similar to below:

ALTER TABLE tablename CHANGE field field DOUBLE PRECISION NOT NULL;

Running this has no effect on the database and subsequent calls will try to run the same SQL.

I have created a pull request in GitHub which fixes the issue.

@doctrinebot
Copy link
Author

@doctrinebot
Copy link
Author

Issue was closed with resolution "Fixed"

@doctrinebot
Copy link
Author

Comment created by patkar:

Can I backport the fix to the 2.5 branch?

@doctrinebot doctrinebot added this to the 2.6 milestone Dec 6, 2015
cliffparnitzky added a commit to ContaoMonitoring/monitoring that referenced this issue Jun 28, 2017
@Ocramius Ocramius changed the title DBAL-1082: SchemaTool does not generate SQL for MySQL unsigned float DBAL-1082: SchemaTool does not generate DDL for MySQL unsigned float Jul 22, 2017
@github-actions
Copy link

github-actions bot commented Aug 5, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants