Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test OracleDB abstractions in a continuous integration environment #2626

Closed
photodude opened this issue Jan 31, 2017 · 13 comments
Closed

Test OracleDB abstractions in a continuous integration environment #2626

photodude opened this issue Jan 31, 2017 · 13 comments
Assignees
Milestone

Comments

@photodude
Copy link
Contributor

Apparently, someone has a workaround for testing Oracle DB on travis ci as well https://github.com/cbandy/travis-oracle

an Oracle account is required and the Oracle username and password has to be in the build environment variables either as hidden repository settings or encrypted variables

@Ocramius
Copy link
Member

Ocramius commented Feb 1, 2017

Talked at PHPBenelux with @continuousphp: they can provide CI for OracleDB too (can be integrated here)

@DeepDiver1975
Copy link
Contributor

I've been chatting with @deeky666 these days - owncloud is willing to support the doctrine project here as well.

@Ocramius
Copy link
Member

Ocramius commented Feb 1, 2017

I'm fine with any approach, but it needs to be directly integrated with the PR feedback and commit CI status

@deeky666
Copy link
Member

deeky666 commented Feb 1, 2017

@DeepDiver1975 did you have time to investigate integration possibilities already? @Ocramius can you tell something about the approach you guys discussed?

@Ocramius
Copy link
Member

Ocramius commented Feb 1, 2017

@deeky666 @continuousphp is pretty much similar to travis-ci, but custom containers are provided. The deal is simple: building with continuousphp provides some visibility for them, but they also have to provide a patch with the oracledb testing (multiple versions).

@DeepDiver1975
Copy link
Contributor

What I can offer: run PR testing on jenkins - similar to what is done already today: https://jenkins.owncloud.org/view/doctrine/

As of today we are only testing against oracle xe 11g

@deeky666
Copy link
Member

deeky666 commented Feb 1, 2017

@Ocramius I tried out @continuousphp. See here

Seems to be pretty straight forward. Should we add such a setup for now to at least be able to test one Oracle environment? I could PR that damn thing.

@Ocramius
Copy link
Member

Ocramius commented Feb 1, 2017

@DeepDiver1975 your offer is very kind, but let's try the @continuousphp setup first, mostly because that reduces the amount of customization and internal knowledge (CI PaaS is preferrable). @deeky666 I'd say that we can proceed there, and then fallback to custom jenkins ( @DeepDiver1975's ) if that fails.

@deeky666
Copy link
Member

deeky666 commented Feb 4, 2017

PR created: #2630

@Ocramius Ocramius modified the milestones: 2.6, 2.5.11 Feb 4, 2017
@Ocramius
Copy link
Member

Ocramius commented Feb 4, 2017

This is an improvement, therefore moved to 2.6

@deeky666
Copy link
Member

deeky666 commented Feb 5, 2017

@Ocramius while I agree that we don't backport improvements, I doubt this policy is useful here. The change is not really related to production code and helps identifying Oracle related bugs in the code. Why shouldn't we want to know if our backports also succeed on Oracle in 2.5?

@Ocramius
Copy link
Member

Ocramius commented Feb 5, 2017

I doubt this policy is useful here.

It may not be useful, but we're really just complicating our setup here, and doing so for the gazillion versions supported in 2.5.* is not gonna make our lives easier. Keeping this on master is a decent tradeoff, IMO

@Ocramius Ocramius changed the title [RFC] testing Oracle DB on travis ci Testing Oracle DB on travis ci Feb 5, 2017
@Ocramius Ocramius changed the title Testing Oracle DB on travis ci Test OracleDB in a continuous integration environment Jul 22, 2017
@Ocramius Ocramius changed the title Test OracleDB in a continuous integration environment Test OracleDB abstractions in a continuous integration environment Jul 22, 2017
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants