Don't use the server_version option to define the vendor name

[javiereguiluz]

In this comment: #2985 (comment) you can see that when using MariaDB, the server_version option must include not only the version number but also the vendor name: server_version: 'mariadb-10.2.12' instead of server_version: '10.2.12'.

I wonder if this could be solved differently to keep the vendor name out of the server_version value. Thanks for your time and consideration!

[Ocramius]

The server version is what we'd expect from a server being queried for a server version. You can think of it as the same as an user agent header in a browser: not something we have control over. What can be done is allowing selection of the platform via class name (I think that might already be possible, jus didn't check).

…

On Mon, 16 Apr 2018, 09:35 Javier Eguiluz, ***@***.***> wrote: In this comment: #2985 (comment) <#2985 (comment)> you can see that when using MariaDB, the server_version option must include not only the version number but also the vendor name: server_version: 'mariadb-10.2.12' instead of server_version: '10.2.12'. I wonder if this could be solved differently to keep the vendor name out of the server_version value. Thanks for your time and consideration! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3110>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakKO-WdG97E2GIOUwZ2OnSgusqd_9ks5tpEmkgaJpZM4TWAdO> .

[javiereguiluz]

I don't use MariaDB (maybe @tristanbes, the original issue reporter, can help us here) but it looks like the version returned by MariaDB follows a different format. According to their official docs (https://mariadb.com/kb/en/library/version/) it would be something like this: 10.0.3-MariaDB-1~precise-log

[tristanbes]

I confirm that the format is different:
Connecting to the database via the cli gives something like (but this may differs depending on distributions):

Your MariaDB connection id is 14
Server version: 10.2.14-MariaDB-10.2.14+maria~stretch-log mariadb.org binary distribution

Copyright (c) 2000, 2018, Oracle, MariaDB Corporation Ab and others.

[belgattitude]

For the full story: read the first paragraph in #2825 about the mariadb version detection.

MariaDB server returns the version with their vendor name (+ some prefixes or suffixes are added per distributions to handle some replications issues). Their clients 'libmariadb-client', connector/j'... will strip the vendors and prefixes transparently... In other words if you're using jdbc or php compiled with libmariadb-client, you won't see the 'mariadb' vendor.

Some tentatives have been done to strip it in the php src too (like php/php-src#1767... or others I cannot find anymore). But till now we need to strip the prefix in userland.

In DBAL, it's done here:

dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php

Line 167 in 8392c26

private function getMariaDbMysqlVersionNumber(string $versionString) : string

And the corresponding test file:

dbal/tests/Doctrine/Tests/DBAL/Driver/AbstractMySQLDriverTest.php

Line 67 in 8392c26

['10.0.15-MariaDB-1~wheezy', MySqlPlatform::class],

[belgattitude]

I like the idea of @Ocramius

What can be done is allowing selection of the platform via class name (I think that might already be possible, jus didn't check).

@javiereguiluz do you think it would be ok ?

[morozov]

What can be done is allowing selection of the platform via class name (I think that might already be possible, jus didn't check).

Passing a platform is already possible:

dbal/src/Connection.php

Lines 175 to 181 in d3c7081

	if (isset($params['platform'])) {
	if (! $params['platform'] instanceof Platforms\AbstractPlatform) {
	throw Exception::invalidPlatformType($params['platform']);
	}
	$this->platform = $params['platform'];
	}

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.