Comparator incorrectly diffs default values (regression in master) #3336
Comments
This was referenced Nov 23, 2018
morozov
added a commit
to morozov/dbal
that referenced
this issue
Nov 24, 2018
…ir PHP types Fixes doctrine#3336.
morozov
added a commit
to morozov/dbal
that referenced
this issue
Nov 24, 2018
…ir PHP types Fixes doctrine#3336.
morozov
added a commit
to morozov/dbal
that referenced
this issue
Nov 24, 2018
…ir PHP types Fixes doctrine#3336.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
BC Break Report
Summary
After applying Doctrine CS 5.0, weak comparisons became strict comparisons.
One of the affected places is Comparator which compares default values as is (always
string|nullfrom the DB while it'sscalar|nullwhen declared in ORM):dbal/lib/Doctrine/DBAL/Schema/Comparator.php
Line 435 in bef35e9
Previous behaviour
The following test works with snapshot/develop/2018-04-17
https://github.com/doctrine/doctrine2/blob/2726636e55fdbdf6fb1ed466f22d34de116fb8f9/tests/Doctrine/Tests/ORM/Functional/SchemaTool/DBAL483Test.php#L24-L41
Current behavior
Comparator now produces diff SQL when
defaultis(int) 0.How to reproduce
Run ORM 2.6 test suite with DBAL 2.9.0-dev.
https://travis-ci.org/doctrine/doctrine2/jobs/448657137#L608
The text was updated successfully, but these errors were encountered: