Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP warning on unknown database with Doctrine DBAL 2.13.x #4645

Closed
mbrodala opened this issue May 12, 2021 · 4 comments · Fixed by #4647
Closed

PHP warning on unknown database with Doctrine DBAL 2.13.x #4645

mbrodala opened this issue May 12, 2021 · 4 comments · Fixed by #4647
Labels
Bug Connections Error Handling mysqli
Milestone
2.13.2

Comments

@mbrodala
Copy link

BC Break Report

Q A
BC Break yes
Version 2.13.1

Summary

Connection attempts to a missing database lead to a PHP warning.

Previous behaviour

No warning was shown.

Current behavior

A PHP warning is issued:

PHP Warning: mysqli::real_connect(): (HY000/1049): Unknown database ...

How to reproduce

  1. Do a connection to a missing database.
  2. With Doctrine DBAL 2.11.x no error occurs
  3. With Doctrine DBAL 2.13.x a PHP warning occurs

Also see Nimut/testing-framework#136 and TYPO3/testing-framework#233 for more specific examples.
@mbrodala mbrodala mentioned this issue May 12, 2021
Closed
@mbrodala mbrodala changed the title PHP Warning: mysqli::real_connect(): (HY000/1049): Unknown database with Doctrine DBAL 2.13.x PHP warning on unknown database with Doctrine DBAL 2.13.x May 12, 2021
@morozov
Copy link
Member

morozov commented May 12, 2021

Could be solved by backporting c9ce80a. This will also solve the test failure on non-Linux operating systems:

1) Doctrine\Tests\DBAL\Driver\Mysqli\MysqliConnectionTest::testRestoresErrorHandlerOnException
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'Network is unreachable'
+'Permission denied'

tests/Doctrine/Tests/DBAL/Driver/Mysqli/MysqliConnectionTest.php:56

morozov added a commit to morozov/dbal that referenced this issue May 12, 2021
@morozov
[doctrineGH-4645] Use error suppression instead of an error handler i…
4cc7fe6 
…n MySQLi Connection
@morozov morozov added this to the 2.13.2 milestone May 12, 2021
@morozov morozov added the Bug label May 12, 2021
@morozov morozov mentioned this issue May 12, 2021
Merged
morozov added a commit to morozov/dbal that referenced this issue May 12, 2021
@morozov
[doctrineGH-4645] Use error suppression instead of an error handler i…
b9b30b2 
…n MySQLi Connection
morozov added a commit to morozov/dbal that referenced this issue May 13, 2021
@morozov
[doctrineGH-4645] Fix SQLServerPlatform::quoteIdentifier()
fde42dd
morozov added a commit to morozov/dbal that referenced this issue May 13, 2021
@morozov
[doctrineGH-4645] Fix SQLServerPlatform::quoteIdentifier()
8809142
morozov added a commit to morozov/dbal that referenced this issue May 13, 2021
@morozov
[doctrineGH-4645] Fix SQLServerPlatform::quoteIdentifier()
cd74d3b
morozov added a commit that referenced this issue May 13, 2021
@morozov
Merge pull request #4647 from morozov/issues/4645
21f5eb5 
[GH-4645] Use error suppression instead of an error handler in MySQLi Connection
mbrodala referenced this issue May 14, 2021
@morozov
Fix issues reported by PHPStan
34b113e
@bmack
Copy link

bmack commented May 14, 2021

@morozov Thank you for this super quick fix 🙇

@morozov morozov linked a pull request May 14, 2021 that will close this issue
[GH-4645] Use error suppression instead of an error handler in MySQLi Connection #4647
Merged
@morozov
Copy link
Member

morozov commented May 14, 2021

@bmack, you're welcome. Closed via #4647.

@morozov morozov closed this as completed May 14, 2021
derrabus added a commit to derrabus/dbal that referenced this issue Jun 5, 2021
@derrabus
Merge branch '2.13.x'
ec52079 
* 2.13.x:
  Bump doctrine/coding-standard
  [doctrineGH-4643] Fix SQLServerPlatform::quoteIdentifier()
  [doctrineGH-4645] Use error suppression instead of an error handler in MySQLi Connection
  Rewrote `DriverManagerTest` replica/shards test scenarios to verify whole data structure equality
  Add type-inference tests to github actions, so that we test also that types match up
  Add warnings in docblocks
  Rework the caching documentation
  Fix doctrine#4637 by duplicating the type definition for `DriverManager::getConnection($args)` params
derrabus added a commit to derrabus/dbal that referenced this issue Jun 5, 2021
@derrabus
Merge branch '2.13.x'
e17571f 
* 2.13.x:
  Bump doctrine/coding-standard
  [doctrineGH-4643] Fix SQLServerPlatform::quoteIdentifier()
  [doctrineGH-4645] Use error suppression instead of an error handler in MySQLi Connection
  Rewrote `DriverManagerTest` replica/shards test scenarios to verify whole data structure equality
  Add type-inference tests to github actions, so that we test also that types match up
  Add warnings in docblocks
  Rework the caching documentation
  Fix doctrine#4637 by duplicating the type definition for `DriverManager::getConnection($args)` params
derrabus added a commit to derrabus/dbal that referenced this issue Jun 5, 2021
@derrabus
Merge branch '2.13.x'
63da56a 
* 2.13.x:
  Bump doctrine/coding-standard
  [doctrineGH-4643] Fix SQLServerPlatform::quoteIdentifier()
  [doctrineGH-4645] Use error suppression instead of an error handler in MySQLi Connection
  Rewrote `DriverManagerTest` replica/shards test scenarios to verify whole data structure equality
  Add type-inference tests to github actions, so that we test also that types match up
  Add warnings in docblocks
  Rework the caching documentation
  Fix doctrine#4637 by duplicating the type definition for `DriverManager::getConnection($args)` params
derrabus added a commit to derrabus/dbal that referenced this issue Jun 5, 2021
@derrabus
Merge branch '2.13.x'
0db9cd9 
* 2.13.x:
  Bump doctrine/coding-standard
  [doctrineGH-4643] Fix SQLServerPlatform::quoteIdentifier()
  [doctrineGH-4645] Use error suppression instead of an error handler in MySQLi Connection
  Rewrote `DriverManagerTest` replica/shards test scenarios to verify whole data structure equality
  Add type-inference tests to github actions, so that we test also that types match up
  Add warnings in docblocks
  Rework the caching documentation
  Fix doctrine#4637 by duplicating the type definition for `DriverManager::getConnection($args)` params
derrabus added a commit to derrabus/dbal that referenced this issue Jun 6, 2021
@derrabus
Merge branch '2.13.x'
b02c367 
* 2.13.x:
  Bump doctrine/coding-standard
  [doctrineGH-4643] Fix SQLServerPlatform::quoteIdentifier()
  [doctrineGH-4645] Use error suppression instead of an error handler in MySQLi Connection
  Rewrote `DriverManagerTest` replica/shards test scenarios to verify whole data structure equality
  Add type-inference tests to github actions, so that we test also that types match up
  Add warnings in docblocks
  Rework the caching documentation
  Fix doctrine#4637 by duplicating the type definition for `DriverManager::getConnection($args)` params
derrabus added a commit to derrabus/dbal that referenced this issue Jun 7, 2021
@derrabus
Merge branch '2.13.x' into merge/2.13.x
4fdc8f9 
* 2.13.x:
  Bump doctrine/coding-standard
  [doctrineGH-4643] Fix SQLServerPlatform::quoteIdentifier()
  [doctrineGH-4645] Use error suppression instead of an error handler in MySQLi Connection
  Rewrote `DriverManagerTest` replica/shards test scenarios to verify whole data structure equality
  Add type-inference tests to github actions, so that we test also that types match up
  Add warnings in docblocks
  Rework the caching documentation
  Fix doctrine#4637 by duplicating the type definition for `DriverManager::getConnection($args)` params

Signed-off-by: Alexander M. Turek <me@derrabus.de>
derrabus added a commit to derrabus/dbal that referenced this issue Jun 7, 2021
@derrabus
Merge branch '2.13.x'
e6add29 
* 2.13.x:
  Bump doctrine/coding-standard
  [doctrineGH-4643] Fix SQLServerPlatform::quoteIdentifier()
  [doctrineGH-4645] Use error suppression instead of an error handler in MySQLi Connection
  Rewrote `DriverManagerTest` replica/shards test scenarios to verify whole data structure equality
  Add type-inference tests to github actions, so that we test also that types match up
  Add warnings in docblocks
  Rework the caching documentation
  Fix doctrine#4637 by duplicating the type definition for `DriverManager::getConnection($args)` params

Signed-off-by: Alexander M. Turek <me@derrabus.de>
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Connections Error Handling mysqli
Projects
None yet
Milestone
2.13.2
Development

Successfully merging a pull request may close this issue.

[GH-4645] Use error suppression instead of an error handler in MySQLi Connection morozov/dbal
3 participants
@morozov @bmack @mbrodala