Incorrect assert on AbstractSQLServerDriver connection

[elavrom]

Bug Report

Q	A
Version	3.4.0

Summary

On SQL Server platform, having a custom doctrine.dbal.connections[].platform_service that extends SQLServerPlatform, the call for AbstractSQLServerDriver::getSchemaManager() breaks due to an incorrect assert.

Current behaviour

The assertion in getSchemaManager() fails because it is as follows :

# \Doctrine\DBAL\Driver\AbstractSQLServerDriver: line 43
assert($platform instanceof SQLServer2012Platform);

My custom platform is extending SQLServerPlatform to prevent the deprecation, so this assertion fails

How to reproduce

# src/Doctrine/DBAL/Platforms/SQLServerPlatform.php
namespace App\Doctrine\DBAL\Platforms;

use Doctrine\DBAL\Platforms\SQLServerPlatform as DoctrineSQLServerPlatformAlias;

class SQLServerPlatform extends DoctrineSQLServerPlatformAlias
{
}

# config/packages/doctrine.yaml
# ...
doctrine:
  dbal:
    platform_service: 'App\Doctrine\DBAL\Platforms\SQLServerPlatform'
# ...

# Anywhere 

$em->getConnection()->createSchemaManager();

Expected behaviour

The assert should not fail, I guess it should be replaced by the new class instead of the deprecated one :

# \Doctrine\DBAL\Driver\AbstractSQLServerDriver: line 43
assert($platform instanceof SQLServerPlatform);

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.