Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect an SQLServerPlatform instance in AbstractSQLServerDriver #5585

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

morozov
Copy link
Member

@morozov morozov commented Aug 10, 2022

Q A
Type bug

The SQLServerPlatform class was reinstated in #4755 (3.2.0). The driver should allow using the most low-level of the corresponding platform classes. This would be consistent with the expectation of its schema manager (which is what this assertion is used for):

* @extends AbstractSchemaManager<SQLServerPlatform>

Fixes #5583.

@morozov morozov added this to the 3.4.1 milestone Aug 10, 2022
@morozov morozov marked this pull request as ready for review August 10, 2022 17:23
@morozov morozov requested a review from derrabus August 10, 2022 17:23
@morozov morozov merged commit 564edcd into doctrine:3.4.x Aug 10, 2022
@morozov morozov deleted the issues/5583 branch August 10, 2022 19:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect assert on AbstractSQLServerDriver connection
2 participants