DBAL-49 and DBAL-36 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you send this pull request to Benjamin as well? |
|
I don't know enough to say yes or no. But to me the commit looks weird. What is it fixing? It seems you are just removing some code but I don't see anything added to replace it? |
|
It should have been sent to the whole core team, so Benjamin must have gotten it. This is how it fixes it, by removing code which is wrong mostly. It's all about DSN pretty much. |
|
I merged the code. |
|
Cool! Thanks Benjamin! |
guilhermeblanco
added a commit
that referenced
this pull request
Jan 23, 2013
…ple. Fix connection execute query example
This was referenced Dec 6, 2015
asgrim
pushed a commit
to asgrim/dbal
that referenced
this pull request
Dec 15, 2015
Change order of parameters in doModifyLimitQuery to work with Migrations
morozov
added a commit
that referenced
this pull request
Jun 10, 2019
The new version contains some improvements in handling mocks (sebastianbergmann/phpunit#3602) and will help identify some existing issues in DBAL 3.0 tests: There were 2 warnings: 1) Doctrine\Tests\DBAL\Driver\OCI8\OCI8StatementTest::testExecute with data set #0 (array('test', null, 'value')) Method bindValue may not return value of type boolean 2) Doctrine\Tests\DBAL\Driver\OCI8\OCI8StatementTest::testExecute with data set #1 (array(null, 'test', 'value')) Method bindValue may not return value of type boolean
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.