Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBAL-83: BigInt type is missing the convertToPHPValue method #16

Closed
wants to merge 1 commit into from
Closed

DBAL-83: BigInt type is missing the convertToPHPValue method #16

wants to merge 1 commit into from

Conversation

milokmet
Copy link
Contributor

@beberlei
Copy link
Member

On 32 bit machines a Bigint can be larger as PHP_MAX_INT, that is why its not converted to an int instead kept as a string. Maybe someone needs to use bcmath for it and such.

@milokmet
Copy link
Contributor Author

Ah yes. But then there is one failing test case on PostgreSQL.

  1. Doctrine\Tests\DBAL\Functional\TypeConversionTest::testIdempotentDataConversion with data set Some code optimization in Connection class #3 ('bigint', 12345678, 'string')
    The expected type from the conversion to and back from the database should be string
    Failed asserting that integer:12345678 is of type "string".

/usr/share/php/Doctrine2/dbal/tests/Doctrine/Tests/DBAL/Functional/TypeConversionTest.php:84

I don't understant, why only postgres has this problem.
But this is not my issue. I just want to test DBAL against mysql, postgres and oracle, and this failure I found in postgres.

franbenz pushed a commit to franbenz/dbal that referenced this pull request Oct 18, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants