Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arbitrary line number from github link in the caching documentation #2382

Merged
merged 1 commit into from
May 9, 2016

Conversation

jacobhenke
Copy link
Contributor

No description provided.

@jacobhenke
Copy link
Contributor Author

Actually, I think I may be misunderstanding what the documentation is saying?

@Ocramius
Copy link
Member

Ocramius commented May 9, 2016

The issue here is that the linking was done against master, and not a fixed commit. The line may have moved by now...

I think the patch is fine/sufficient tho, merging.

@Ocramius Ocramius self-assigned this May 9, 2016
@Ocramius Ocramius merged commit 1c6f63d into doctrine:master May 9, 2016
@Ocramius Ocramius added this to the 2.6 milestone May 9, 2016
@jacobhenke
Copy link
Contributor Author

Yay! My first official open source commit! haha

@Ocramius Ocramius changed the title Remove arbitrary line number from github link Remove arbitrary line number from github link in the caching documentation Jul 22, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants