Hotfix 2313 infinite loop #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-2313-infinite-loop
|
Test case required |
|
Thought I'd submitted this PR back in February, but clearly I didn't, and the error is still there. |
…ause scrubbing is working correctly and not entering an infinite loop
|
Tests added (one for a query with a clause that needs to be scrubbed, and one that just gets reordered without scrubbing anything). Also, this should if not fix issue #2374, then it should at least negate the infinite loop part of the issue, as it breaks out of that loop which their query also triggered. |
|
@TwoWholeWorms isn't this a duplicate of #2341 ? |
|
/cc @billschaller |
|
Hi, I just wanted to know what the status of this PR is? There hasn't been any progress in the last six months but the error still exists. |
|
LGTM, Thanks! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
String offset cast occurreddue to poor parsing of the SQL query being checked by checking if the string being searched for was actually found and then breaking if it is not.