Replacing spaces in the pgsql DSN string with semicolons for consistency with pdo_pgsql #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore consistent with the other drivers and makes the PDOPgSQL driver work in hhvm 3.15.2 as well.
|
@Chrisissorry the pgsql dsn string separator issue was solved in the recent hhvm 3.15.3 release (although I don't disagree that consistency is recommended) |
deeky666
added
Drivers
Improvement
Oracle
Connecting
pdo_pgsql
PostgreSQL
and removed
Oracle
labels
deeky666
approved these changes
Jan 14, 2017
|
@Chrisissorry thx! |
|
@deeky666 Thanks for accepting! |
Ocramius
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ore consistent with the other drivers and makes the PDOPgSQL driver work in hhvm 3.15.2 as well.