Add oci8 persistent connection support to the configuration documentation #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The oci8 driver can connect using oci_pconnect to make persistent connections. Doctrine has support for this if the persistent boolean value is set to true in the documentation. However, this information was not documented.
Ocramius
suggested changes
Feb 25, 2017
| @@ -305,6 +305,7 @@ pdo\_oci / oci8 | |||
| you will still need to provide the ``user`` and ``password`` parameters, but the other | |||
| parameters will no longer be used. Note that when using this parameter, the ``getHost`` | |||
| and ``getPort`` methods from ``Doctrine\DBAL\Connection`` will no longer function as expected. | |||
| - ``persistent`` (boolean): Whether to establish a persistent connection. | |||
There was a problem hiding this comment.
Please indent as in previous bullet points
There was a problem hiding this comment.
I don't understand, it has the same indentation here. And the generated HTML has exactly the same structure: https://github.com/mathieubouchard/dbal/blob/master/docs/en/reference/configuration.rst
There was a problem hiding this comment.
Urgh, sorry for that, the spacing is shown differently on github for mobile devices - my bad :-(
Ocramius
approved these changes
Feb 25, 2017
|
@mathieubouchard merging, thanks! 👍 |
Ocramius
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The oci8 driver can connect using oci_pconnect to make persistent connections. Doctrine has support for this if the persistent boolean value is set to true in the configuration. However, this information was not documented.