Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting references to Driver\Connection in the documentation #2736

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Correcting references to Driver\Connection in the documentation #2736

merged 1 commit into from
Jun 6, 2017

Conversation

b0nd0
Copy link
Contributor

@b0nd0 b0nd0 commented Jun 6, 2017 •
edited
Loading

At least it looks like one to me.

@b0nd0
Misspell in documentation
e5e2036 
At lest it looks like one to me.
Ocramius
Ocramius suggested changes Jun 6, 2017
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be https://github.com/doctrine/dbal/blob/v2.5.0/lib/Doctrine/DBAL/Driver.php

Also, please make a more descriptive commit/issue title 👍

@b0nd0 b0nd0 changed the title Misspell in documentation Wrong class used in documentation. Jun 6, 2017
@b0nd0
Copy link
Contributor Author

b0nd0 commented Jun 6, 2017

Thanks for such quick response, i'll try to name pull requests better next time.
But speaking about changes, as far as i understand:

The drivers abstract a PHP specific database API by enforcing two interfaces:
...
The above two interfaces require exactly the same methods as PDO.

it should be connection and statement, isn't it? DBAL\Driver doesn't look like PHP PDO class

@Ocramius
Copy link
Member

Ocramius commented Jun 6, 2017

@b0nd0 ah, yep, my bad!

@Ocramius Ocramius changed the title Wrong class used in documentation. Wrong class used in documentation - referenced Driver instead of Driver\Connection Jun 6, 2017
@Ocramius Ocramius self-assigned this Jun 6, 2017
@Ocramius Ocramius added this to the 2.6 milestone Jun 6, 2017
@Ocramius Ocramius merged commit b331b1e into doctrine:master Jun 6, 2017
@Ocramius
Copy link
Member

Ocramius commented Jun 6, 2017

@b0nd0 thanks! \o/

@Ocramius Ocramius changed the title Wrong class used in documentation - referenced Driver instead of Driver\Connection Corecting references to Driver\Connection in the documentation Jul 22, 2017
@Ocramius Ocramius changed the title Corecting references to Driver\Connection in the documentation Correcting references to Driver\Connection in the documentation Jul 22, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Documentation
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@b0nd0 @Ocramius