-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation regarding transactional exceptions #2760
Add documentation regarding transactional exceptions #2760
Conversation
b9bcfed
to
2bcc75f
Compare
docs/en/reference/transactions.rst
Outdated
If you want to handle errors related to deadlocks or lock wait timeouts you can use | ||
|
||
It is best practice to implement retry logic for transactions that are aborted because of deadlocks or timeouts. | ||
Doctrine provides built-in exceptions for these kind of errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these kindS
docs/en/reference/transactions.rst
Outdated
Error handling | ||
-------------- | ||
|
||
If you want to handle errors related to deadlocks or lock wait timeouts you can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sentence is cut off
docs/en/reference/transactions.rst
Outdated
It is best practice to implement retry logic for transactions that are aborted because of deadlocks or timeouts. | ||
Doctrine provides built-in exceptions for these kind of errors. | ||
|
||
Transaction exceptions have a marker interface: ``Doctrine/DBAL/Exception/RetryableException`` and based on the . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on the .
?
docs/en/reference/transactions.rst
Outdated
Doctrine provides built-in exceptions for these kind of errors. | ||
|
||
Transaction exceptions have a marker interface: ``Doctrine/DBAL/Exception/RetryableException`` and based on the . | ||
A practical example is as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specify what kind of example this is - what is it for?
my bad, amended with the real changes. |
2bcc75f
to
7b4479b
Compare
🚢 |
Fixes #2290