Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation regarding transactional exceptions #2760

Merged

Conversation

dsantang
Copy link
Contributor

Fixes #2290

@dsantang dsantang force-pushed the document-retryable-transactional-errors branch 2 times, most recently from b9bcfed to 2bcc75f Compare June 29, 2017 19:29
If you want to handle errors related to deadlocks or lock wait timeouts you can use

It is best practice to implement retry logic for transactions that are aborted because of deadlocks or timeouts.
Doctrine provides built-in exceptions for these kind of errors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these kindS

Error handling
--------------

If you want to handle errors related to deadlocks or lock wait timeouts you can use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentence is cut off

It is best practice to implement retry logic for transactions that are aborted because of deadlocks or timeouts.
Doctrine provides built-in exceptions for these kind of errors.

Transaction exceptions have a marker interface: ``Doctrine/DBAL/Exception/RetryableException`` and based on the .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the .?

Doctrine provides built-in exceptions for these kind of errors.

Transaction exceptions have a marker interface: ``Doctrine/DBAL/Exception/RetryableException`` and based on the .
A practical example is as follows:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify what kind of example this is - what is it for?

@dsantang
Copy link
Contributor Author

my bad, amended with the real changes.

@Ocramius Ocramius self-assigned this Jun 29, 2017
@Ocramius Ocramius added this to the 2.6 milestone Jun 29, 2017
@dsantang dsantang force-pushed the document-retryable-transactional-errors branch from 2bcc75f to 7b4479b Compare June 29, 2017 19:36
@Ocramius Ocramius merged commit 9ecfda6 into doctrine:master Jun 29, 2017
@Ocramius
Copy link
Member

🚢

@dsantang dsantang deleted the document-retryable-transactional-errors branch June 29, 2017 19:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants