Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue when number of positional parameters != number of given types #301

Merged
merged 1 commit into from
Apr 8, 2013
Merged

Fixing issue when number of positional parameters != number of given types #301

merged 1 commit into from
Apr 8, 2013

Conversation

lstrojny
Copy link
Contributor

@lstrojny lstrojny commented Apr 8, 2013

When passing incomplete type information to Connection::query(), SQLParserUtils currently behaves the wrong way as it ignores all typing information instead falling back to a default (PDO::PARAM_STR). I don’t know this place very well, so please review carefully.

guilhermeblanco added a commit that referenced this pull request Apr 8, 2013
…aults

Fixing issue when number of positional parameters != number of given types
@guilhermeblanco guilhermeblanco merged commit 589a5fb into doctrine:master Apr 8, 2013
@lstrojny lstrojny deleted the bugfix/positional-parameter-defaults branch April 8, 2013 21:41
@beberlei
Copy link
Member

I had to revert this merge, because of http://www.doctrine-project.org/jira/browse/DBAL-496

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants