Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes from PHPStan l1 for tests #3063

Merged
merged 2 commits into from
Jun 18, 2018
Merged

Fixes from PHPStan l1 for tests #3063

merged 2 commits into from
Jun 18, 2018

Conversation

carusogabriel
Copy link
Contributor

@carusogabriel carusogabriel commented Mar 20, 2018 •
edited
Loading

Waiting for #3025, but not ready to enable PHPStan at tests/ yet.

@Ocramius
Copy link
Member

Some unrelated CS issues were found here: unsure if worth fixing or better to just merge and let diffcs shut up with the next PR.

@Ocramius Ocramius added this to the 3.0.0 milestone Mar 20, 2018
@carusogabriel
Copy link
Contributor Author

carusogabriel commented Mar 20, 2018 •
edited
Loading

@Ocramius Is up to you :)

I’d love to start fix CS in dbal, but @Majkl578 asked to wait before development ends, so 👍 for merge this and fix CS in the future

@Ocramius
Copy link
Member

@carusogabriel as long as it doesn't break other PRs

@carusogabriel
Copy link
Contributor Author

Can we merge this one with only one small CS violation?

Ocramius
Ocramius approved these changes Jun 18, 2018
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

@Ocramius Ocramius merged commit 89a52c2 into doctrine:master Jun 18, 2018
@carusogabriel carusogabriel deleted the phpstan-tests branch June 18, 2018 10:25
@morozov morozov modified the milestones: 4.0.0, 2.10.2 Aug 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@carusogabriel carusogabriel

Labels
Improvement
Projects
None yet
Milestone
2.10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@carusogabriel @Ocramius @morozov