Deprecated usage of binary fields whose length exceeds the platform maximum #3188

morozov · 2018-06-19T05:16:12Z

Closes #3187.

Majkl578 · 2018-06-19T22:41:44Z

lib/Doctrine/DBAL/Platforms/AbstractPlatform.php

+        if ($field['length'] > $maxLength) {
+            if ($maxLength > 0) {
+                @trigger_error(sprintf(
+                    'Binary field length %d is greater than supported by the platform (%d)',


Can we also add a hint here? "use getBlobTypeDeclarationSQL() instead"

It may be confusing. Besides using a blob, a user may want to reduce the length of the field. Also, most likely, a user is not calling this method directly, it's called based on their entity definitions.

What about: reduce the field size or use a BLOB field instead?

Sounds good. 👍

Hah @Ocramius was too fast. 😂

Ocramius

LGTM 👍

…aximum Closes doctrine#3187.

morozov · 2018-06-19T22:53:31Z

@Majkl578 @Ocramius did you guys just see a race condition here? I force-pushed the updated branch a moment before the pull request got merged, it invalidated the review but still let the merge happen. Both the merge and invalidation happened on the same second: 3:48 PDT.

Ocramius · 2018-06-19T22:55:06Z

Yeah, saw the dismissed review.

Is the current master state diffing anything with your local dev branch?

Majkl578 · 2018-06-19T22:58:01Z

Yup, noticed, original commit got merged, the new one interestingly only fired ContinuousPHP build which immediately failed.
Nice!

@morozov Can you send the reworded patch in new PR? 👍

morozov · 2018-06-19T23:38:31Z

Is the current master state diffing anything with your local dev branch?

Actually yes (#3192). What I thought, is the changes I force-pushed got merged even if they weren't approved. So, false alarm.

@morozov

Release v2.8.0 [![Build Status](https://travis-ci.org/doctrine/dbal.svg?branch=v2.8.0)](https://travis-ci.org/doctrine/dbal) This is a minor release of Doctrine DBAL that aggregates over 30 fixes and improvements developed over the last 3 months. This release includes all changes of the 2.7.x series, as well as feature additions and improvements that couldn’t land in patch releases. **Backwards Compatibility Breaks** This doesn't contain any intentional Backwards Compatibility (BC) breaks. **Dependency Changes** * The dependency on [doctrine/common](https://github.com/doctrine/common) is removed. DBAL now depends on [doctrine/cache](https://github.com/doctrine/cache) and [doctrine/event-manager](https://github.com/doctrine/event-manager) instead. Please see details in the [UPGRADE.md](UPGRADE.md) documentation. **Deprecations** * The usage of binary fields whose length exceeds the maximum field size on a given platform is deprecated. Please use binary fields of a size which fits all target platforms, or use blob explicitly instead. * The usage of DB-generated UUIDs is deprecated. Their format is inconsistent across supported platforms and therefore the feature is not portable. Use a PHP library (e.g. [ramsey/uuid](https://packagist.org/packages/ramsey/uuid)) to generate UUIDs on the application side. **New features** * Initial support of MySQL 8. * Initial support of PostgreSQL 11. * Ability to evaluate arbitrary SQL expressions via `AbstractPlatform::getDummySelectSQL()`. **Improvements and Fixes** * Improved support of binary fields on Oracle and IBM DB2. * Improved SQL Server configuration capabilities via both `sqlsrv` and `pdo_sqlsrv`. * Improved handling of `AUTOINCREMENT`ed primary keys in SQLite. * Integration tests are run against IBM DB2 on Travis CI. * Code coverage is collected for the Oracle platform on continuousphp. Total issues resolved: **33** **Deprecations:** - [3187: Deprecate usage of binary fields whose length exceeds maximum](doctrine#3187) thanks to @morozov - [3188: Deprecated usage of binary fields whose length exceeds the platform maximum](doctrine#3188) thanks to @morozov - [3192: Added more information to the deprecation notice](doctrine#3192) thanks to @morozov - [3212: Deprecated usage of DB-generated UUIDs](doctrine#3212) thanks to @morozov **New Features:** **Bug Fixes:** - [3149: Introduced binary binding type to support binary parameters on Oracle](doctrine#3149) thanks to @morozov - [3178: Fix incorrect exception thrown from SQLAnywhere16Platform](doctrine#3178) thanks to @Majkl578 - [3044: Functional test for allowing dynamic intervals in date sub/add](doctrine#3044) thanks to @AshleyDawson - [3049: Test failures caused by invalid database connection result in fatal error](doctrine#3049) thanks to @Majkl578 **Improvements:** - [3033: Added support for available DSN parameters for the PDOSqlsrv driver](doctrine#3033) thanks to @aashmelev - [3128: Add MySQL 8 reserved keywords](doctrine#3128) thanks to @mlocati - [3143: initialize sql array into platform files](doctrine#3143) thanks to @AlessandroMinoccheri - [3173: Fix composer branch aliases](doctrine#3173) thanks to @Majkl578 - [3157: When building a limit query, zero offset without a limit should be ignored](doctrine#3157) thanks to @morozov - [3109: Allow to specify arbitrary SQL expression in AbstractPlatform::getDummySelectSQL()](doctrine#3109) thanks to @morozov - [3141: allow creating PRIMARY KEY AUTOINCREMENT fields for sqlite (unit tests)](doctrine#3141) thanks to @TimoBakx - [3180: Import simplified version of Common\Util\Debug for var dumping purposes](doctrine#3180) thanks to @Majkl578 **Documentation Improvements:** - [3117: Added badges for the develop branch in README](doctrine#3117) thanks to @morozov - [3125: Upgrading docs](doctrine#3125) thanks to @jwage - [3144: added improvement type into pull request template](doctrine#3144) thanks to @AlessandroMinoccheri **Code Quality Improvements:** - [3025: Added PHPStan, apply changes for level 3](doctrine#3025) thanks to @Majkl578 - [3200: Php Inspections (EA Ultimate): minor code tweaks](doctrine#3200) thanks to @kalessil - [3204: Fix typo in AbstractPlatform](doctrine#3204) thanks to @Majkl578 - [3205: Ignore OCI-* classes in static analysis (no stubs)](doctrine#3205) thanks to @Majkl578 **Continuous Integration Improvements:** - [3102: Use newer PHPUnit to prevent crashes on failures](doctrine#3102) thanks to @Majkl578 - [3112: Removed hard-coded configuration filenames from the test runner](doctrine#3112) thanks to @morozov - [3133: Travis DB2](doctrine#3133) thanks to @Majkl578, @morozov - [3135: AppVeyor tweaks, retry coverage upload on failure](doctrine#3135) thanks to @Majkl578 - [3137: Workaround for the inability to use a post-PHPUnit script on ContinuousPHP](doctrine#3137) thanks to @morozov - [3151: MSSQL DLL 5.2.0 has been released.](doctrine#3151) thanks to @photodude - [3160: Test against Postgres 11](doctrine#3160) thanks to @Majkl578 **Dependencies** - [3193: DBAL 2.8 needs Common 2.9](doctrine#3193) thanks to @Majkl578 - [3176: Eliminate dependency on doctrine/common](doctrine#3176) thanks to @Majkl578 - [3181: Remove dependency on doctrine/common](doctrine#3181) thanks to @Majkl578 # gpg: Signature made Fri Jul 13 06:02:10 2018 # gpg: using RSA key 374EADAF543AE995 # gpg: Can't check signature: public key not found # Conflicts: # .gitignore # README.md # lib/Doctrine/DBAL/Version.php # tests/appveyor/mssql.sql2008r2sp2.sqlsrv.appveyor.xml # tests/appveyor/mssql.sql2012sp1.sqlsrv.appveyor.xml # tests/appveyor/mssql.sql2017.pdo_sqlsrv.appveyor.xml # tests/appveyor/mssql.sql2017.sqlsrv.appveyor.xml # tests/travis/mariadb.mysqli.travis.xml

morozov added Platforms Types Type Mapping Schema Definition Columns Type Conversion Deprecation labels Jun 19, 2018

morozov added this to the 2.8.0 milestone Jun 19, 2018

morozov self-assigned this Jun 19, 2018

morozov requested a review from Majkl578 June 19, 2018 05:16

Majkl578 reviewed Jun 19, 2018

View reviewed changes

Majkl578 previously approved these changes Jun 19, 2018

View reviewed changes

Ocramius previously approved these changes Jun 19, 2018

View reviewed changes

Deprecated usage of binary fields whose length exceeds the platform m…

cd5045b

…aximum Closes doctrine#3187.

Ocramius assigned Ocramius and unassigned morozov Jun 19, 2018

Ocramius merged commit c0f6d4b into doctrine:master Jun 19, 2018

morozov dismissed stale reviews from Ocramius and Majkl578 via cd5045b June 19, 2018 22:48

morozov force-pushed the issues/3187 branch from a64d748 to cd5045b Compare June 19, 2018 22:48

morozov deleted the issues/3187 branch June 19, 2018 22:53

morozov mentioned this pull request Jun 19, 2018

Added more information to the deprecation notice #3192

Merged

morozov mentioned this pull request Sep 24, 2018

Get rid of hard-coded default values of maximum field lengths #3263

Closed

github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecated usage of binary fields whose length exceeds the platform maximum #3188

Deprecated usage of binary fields whose length exceeds the platform maximum #3188

morozov commented Jun 19, 2018

Majkl578 Jun 19, 2018

morozov Jun 19, 2018

Majkl578 Jun 19, 2018

Majkl578 Jun 19, 2018

Ocramius left a comment

morozov commented Jun 19, 2018 •

edited

Loading

Ocramius commented Jun 19, 2018

Majkl578 commented Jun 19, 2018

morozov commented Jun 19, 2018

Deprecated usage of binary fields whose length exceeds the platform maximum #3188

Deprecated usage of binary fields whose length exceeds the platform maximum #3188

Conversation

morozov commented Jun 19, 2018

Majkl578 Jun 19, 2018

Choose a reason for hiding this comment

morozov Jun 19, 2018

Choose a reason for hiding this comment

Majkl578 Jun 19, 2018

Choose a reason for hiding this comment

Majkl578 Jun 19, 2018

Choose a reason for hiding this comment

Ocramius left a comment

Choose a reason for hiding this comment

morozov commented Jun 19, 2018 • edited Loading

Ocramius commented Jun 19, 2018

Majkl578 commented Jun 19, 2018

morozov commented Jun 19, 2018

morozov commented Jun 19, 2018 •

edited

Loading