Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub template grammar/spelling fixes #3219

Merged
merged 1 commit into from
Jul 15, 2018

Conversation

GwendolenLynch
Copy link
Contributor

Q A
Type improvement
BC Break no
Fixed issues n.a.

Summary

Grammar & spelling fixes for GitHub templates

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thansk for teh fiexs!

@Ocramius Ocramius self-assigned this Jul 15, 2018
@Ocramius Ocramius added this to the 2.9.0 milestone Jul 15, 2018
@Ocramius Ocramius merged commit a7dc38d into doctrine:2.8 Jul 15, 2018
@GwendolenLynch GwendolenLynch deleted the hotfix/github-templates branch July 15, 2018 20:02
@Majkl578
Copy link
Contributor

This shouldn't have been merged into 2.8.

@Ocramius
Copy link
Member

Ocramius commented Jul 16, 2018 via email


#### Previous behavior
#### Previous behaviour
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:trollface:

@GwendolenLynch
Copy link
Contributor Author

This shouldn't have been merged into 2.8.

Ugh, my bad too for the choice of branch. I blame the lack of 🍻

@Majkl578
Copy link
Contributor

Can you please send the same patch against master? We don't merge up from lower branches.

@GwendolenLynch
Copy link
Contributor Author

On it!

@Majkl578 Majkl578 removed this from the 2.9.0 milestone Jul 16, 2018
@morozov morozov added this to the 2.8.1 milestone Nov 2, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants