Ignore case when matching ARRAY #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this fixing #3140? |
|
@ohvitorino please target DBAL |
ohvitorino
force-pushed
the
fix-lost-parameters-wrong-ESCAPED_BRACKET_QUOTED_TEXT
branch
from
75a5224 to
874eff3
Compare
morozov
previously approved these changes
Jul 24, 2018
|
@ohvitorino please fix the code style issues before I can merge it. |
|
@morozov the php code sniffer configuration being used expects, for example, short array syntax. But the whole file uses the |
|
Yes, it's only about the changed lines. Fixing the entire file will happen
in `develop` anyway
…On Wed, 8 Aug 2018, 08:41 Bruno Vitorino, ***@***.***> wrote:
@morozov <https://github.com/morozov> the php code sniffer configuration
being used expects, for example, short array syntax. But the whole file
uses the array() syntax, should I then change the whole file or only the
lines I changed in my PR? Changing only a couple of statements to comply
with the expected code style seems a bit inconsistent.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3226 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAJakBMDrV6pHoF-TnGY5u7ml9FEHr8vks5uOogEgaJpZM4VbJcv>
.
|
|
@morozov Code styles are fixed 🙂 |
|
@ohvitorino thank you. Please, also squash. We don't squash commits ourselves anymore. |
ohvitorino
force-pushed
the
fix-lost-parameters-wrong-ESCAPED_BRACKET_QUOTED_TEXT
branch
from
af60eb5 to
5682b66
Compare
|
@morozov done and building |
morozov
approved these changes
Sep 1, 2018
|
Thank you, @ohvitorino! Merged. |
|
Backported to |
wizhippo
pushed a commit
to wizhippo/doctrine-dbal
that referenced
this pull request
Nov 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Named parameters get lost because the regular expression used to determine the query fragments only match the keyword
ARRAY(capital letters). This should be made case insensitive since this is also correct syntax.