Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Got rid of func_num_args() in AbstractPlatform::getDummySelectSQL() #3315

Merged
merged 1 commit into from
Oct 6, 2018
Merged

Got rid of func_num_args() in AbstractPlatform::getDummySelectSQL() #3315

merged 1 commit into from
Oct 6, 2018

Conversation

morozov
Copy link
Member

@morozov morozov commented Oct 6, 2018

Q A
Type improvement
BC Break yes

While working on #3109, we agreed that the method signature couldn't be changed due to BC concerns. Now the method signature is explicit.

@Ocramius Ocramius self-assigned this Oct 6, 2018
@Ocramius Ocramius added this to the 3.0.0 milestone Oct 6, 2018
Ocramius
Ocramius approved these changes Oct 6, 2018
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ocramius Ocramius merged commit c067f0f into doctrine:develop Oct 6, 2018
@morozov morozov deleted the get-dummy-select-sql branch October 6, 2018 19:32
morozov pushed a commit that referenced this pull request Oct 7, 2018
@Ocramius @morozov
Merge pull request #3315 from morozov/get-dummy-select-sql
c4478a0 
Got rid of func_num_args() in AbstractPlatform::getDummySelectSQL()
morozov pushed a commit that referenced this pull request Oct 7, 2018
@Ocramius @morozov
Merge pull request #3315 from morozov/get-dummy-select-sql
e5a586e 
Got rid of func_num_args() in AbstractPlatform::getDummySelectSQL()
morozov pushed a commit that referenced this pull request Nov 14, 2018
@Ocramius @morozov
Merge pull request #3315 from morozov/get-dummy-select-sql
0a11c71 
Got rid of func_num_args() in AbstractPlatform::getDummySelectSQL()
morozov pushed a commit that referenced this pull request Nov 14, 2018
@Ocramius @morozov
Merge pull request #3315 from morozov/get-dummy-select-sql
fa42c10 
Got rid of func_num_args() in AbstractPlatform::getDummySelectSQL()
morozov pushed a commit that referenced this pull request Nov 25, 2018
@Ocramius @morozov
Merge pull request #3315 from morozov/get-dummy-select-sql
0ef7d47 
Got rid of func_num_args() in AbstractPlatform::getDummySelectSQL()
morozov pushed a commit that referenced this pull request Dec 6, 2018
@Ocramius @morozov
Merge pull request #3315 from morozov/get-dummy-select-sql
d986ab4 
Got rid of func_num_args() in AbstractPlatform::getDummySelectSQL()
morozov pushed a commit that referenced this pull request Jan 20, 2019
@Ocramius @morozov
Merge pull request #3315 from morozov/get-dummy-select-sql
5f9c8fb 
Got rid of func_num_args() in AbstractPlatform::getDummySelectSQL()
morozov pushed a commit to morozov/dbal that referenced this pull request Feb 6, 2019
@Ocramius @morozov
Merge pull request doctrine#3315 from morozov/get-dummy-select-sql
302347d 
Got rid of func_num_args() in AbstractPlatform::getDummySelectSQL()
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
BC Break Improvement Platforms
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @Ocramius