CI: Test against PHP 7.3 on Travis #3323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Majkl578
commented
Oct 13, 2018
Majkl578
commented
| Q | A |
|---|---|
| Type | improvement |
morozov
reviewed
Oct 13, 2018
| @@ -140,6 +158,11 @@ jobs: | |||
| env: DB=mariadb MARIADB_VERSION=10.1 | |||
| addons: | |||
| mariadb: 10.1 | |||
| - stage: Test | |||
| php: 7.3 | |||
| env: DB=mariadb MARIADB_VERSION=10.1 | |||
There was a problem hiding this comment.
Given MariaDB 10.0 is tested on PHP 7.3 and MariaDB 10.1 is tested on other PHP versions, it doesn't look like testing on MariaDB 10.1 with PHP 7.3 provides any additional value. Let's try reducing the number of newly introduced jobs to the necessary minimum (e.g. only the newest version of each platform).
BenMorel
added a commit
to BenMorel/dbal
that referenced
this pull request
Nov 15, 2018
As per @morozov's suggestion on Majkl578's original PR: doctrine#3323 (review)
|
Closing in favor of #3347. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.