Improve ConnectionTest by triggering real exceptions #3425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simPod
force-pushed
the
add-functional-tests-for-transactions
branch
from
eb63e74 to
d81d31f
Compare
|
@morozov I rebased this and seems like it's ready for review |
|
@simPod looks good. Please squash (we don't need a commit that fails the build) and rebase on |
simPod
force-pushed
the
add-functional-tests-for-transactions
branch
from
23eb51f to
742dbbb
Compare
|
Done. You'll need to force-push again since there doesn't seem to be any build that I could restart. |
simPod
force-pushed
the
add-functional-tests-for-transactions
branch
6 times, most recently
from
5db16b7 to
87c95ab
Compare
Co-authored-by: Simon Podlipsky <simon@podlipsky.net>
simPod
force-pushed
the
add-functional-tests-for-transactions
branch
from
87c95ab to
0a54d82
Compare
|
It's ready for review now. |
morozov
approved these changes
Aug 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Connectionfunctional test now checks real exceptions triggered by the database and not manually thrown one in the test. Relates to #3424 (review) but may be merged regardless/independently, imo.