Replace self with static in fabric methods for ConversionException #3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitso
changed the title
|
Sorry, but this is an incorrect approach, since there is no guarantee that your child class constructor behaves like the parent one: please use your own implementation of these classes and static methods. |
|
Thanks for quick reply, I see the problem. |
|
Yes, but right now the BC break would be too massive. Please check |
|
Also see #2841. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables compatibility with inherited classes for fabric methods in base exception class.
I like to use
\Doctrine\DBAL\Types\ConversionExceptionfactory methods when working with types.But for custom types I prefer to extend base exception class to get more specific behavior.