Issue #3631 - possible fix for Mysqli #3639
Conversation
Change "we're" to "where" in docblock for listTableColumns() method. Add comma to improve readability.
Bumped PHPUnit requrement to ^8.3.3, removed dependency on symfony/phpunit-bridge
The failures are caused by the changes in PHP according to https://wiki.php.net/rfc/notice-for-non-valid-array-container.
…ainer Fixed test failures on PHP 7.4
Using command line options to configure MySQL 8 instead of mounting a config file
|
Mysql8.0 build failing due to authentication issues, all other tests pass. |
Fix typo in docblock
Would most likely need an integration test. Something that runs |
lib/Doctrine/DBAL/ParameterType.php
Outdated
| /** | ||
| * Represents a double data type. | ||
| */ | ||
| public const DOUBLE = 32; |
There was a problem hiding this comment.
It doesn't have to be a power of two since parameter types do aren't used as bits in a bitmask. Please use 17.
| */ | ||
| public function getBindingType() | ||
| { | ||
| return ParameterType::INTEGER; |
There was a problem hiding this comment.
Why do we want to bind floats as integers?
Please rebase on top of the latest |
Please make sure you reproduce the scenario described in #3631 which warrants the code change. Just using a float in a query already works and doesn't require changes. |
Summary
Create a new DOUBLE type to satisfy the 'd' type necessary for full Mysqli compatibility as referenced here: mysqli_stmt::bind_param.