add sql type parameter to connection project function

[leonhusmann]

Q	A
Type	improvement
BC Break	yes
Fixed issues	none

Summary

I've added the missing sql-type parameter to the project wrapper function.

[SenseException]

Thank you for your PR. What use case do you try to handle with this PR? It would be nice if you can add this to your description of the PR.

[leonhusmann]

Thank you for your PR. What use case do you try to handle with this PR? It would be nice if you can add this to your description of the PR.

I use the types parameter to specify the types of the sql-parameters. That's needed because only then mysql can choose the right index for me. Here is a small example, using the executeQuery function.

$this->connection->executeQuery(
    <<<'SQL'
    SELECT * FROM dummy WHERE number IN (:numberArray)
    SQL,
    [
        'numberArray' => [123, 456],
    ],
    [
        'numberArray' => Connection::PARAM_INT_ARRAY
    ]
);

This is working fine. Now I want to hydrate the rows to structs after the execution. Therefore, I could use the project function which does this for me with my custom callback.
But because of the missing type parameter I then can't specify the sql-parameter as int array and the wrong index will be used.

[morozov]

Rather than mocking 4 classes just in order to make sure that the argument is passed down the line, I'd like to test the real value that passing this parameter introduces for DBAL.

Could you instead come up with a realistic functional test that would show the need for this change?

[morozov]

Looking at this method, I have really no idea why we need it in DBAL in the first place. It contains more limitations and caveats than real use:

1. It fetches all data in memory which is often inefficient (see Add iterators for non pdo drivers. #2718).
2. It fetches rows one by one instead of using fetchAll().
3. Adding $types at the end of the signature makes it look weird since $params and $types logically belong together but they end up separated by $function.
4. It doesn't allow to specify the statement fetch mode since it's instantiated internally.
5. It can be easily replaced with:

   foreach ($conn->executeQuery($query, $params, $types) as $value) {
      yield $function($value);
   }

Why don't we just get rid of it instead of fixing?