Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to PHPStan v0.12 #3799

Merged
merged 12 commits into from
Mar 30, 2020
Merged

Upgrade to PHPStan v0.12 #3799

merged 12 commits into from
Mar 30, 2020

Commits on Mar 29, 2020

  1. Upgrade to PHPStan v0.12 

    Allowing us to use more advanced checks and have full generic support.

This also adds a baseline file, since we have new violations being
reported but don't want to address them right now.
    @lcobucci @morozov
    lcobucci authored and morozov committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    ab88b96 View commit details
    Browse the repository at this point in the history

  2. Respect interface's return type in methods

    @lcobucci @morozov
    lcobucci authored and morozov committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    f440d92 View commit details
    Browse the repository at this point in the history

  3. Declare return types in a BC compatible manner

    @lcobucci @morozov
    lcobucci authored and morozov committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    35beaca View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. Fix argument type declaration 

    By either defining their types or renaming to match parent class (or
interface).
    @lcobucci @morozov
    lcobucci authored and morozov committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    2649ae6 View commit details
    Browse the repository at this point in the history

  2. Do not ignore the result of array_change_key_case()

    @morozov
    morozov committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    d267775 View commit details
    Browse the repository at this point in the history

  3. Assert that the value fetched from the database is always an integer

    @morozov
    morozov committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    e6bfcad View commit details
    Browse the repository at this point in the history

  4. Removed redundant break statements

    @morozov
    morozov committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    e5068b4 View commit details
    Browse the repository at this point in the history

  5. AbstractPlatform::_getTransactionIsolationLevelSQL() must return a st… 

    …ring
    @morozov
    morozov committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    4650d9c View commit details
    Browse the repository at this point in the history

  6. Make sure that the options row was fetched successfully

    @morozov
    morozov committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    c9ec618 View commit details
    Browse the repository at this point in the history

  7. ForeignKeyConstraint::onEvent() must return null as an empty action

    @morozov
    morozov committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    e247a10 View commit details
    Browse the repository at this point in the history

  8. Use strings to work with ini_get() and ini_set() 

    Additionally, set the new value and get the old one in one ini_set() call.
    @morozov
    morozov committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    a56eeee View commit details
    Browse the repository at this point in the history

  9. Disabled some options and whitelisted false-positives

    @morozov
    morozov committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    0d36ac8 View commit details
    Browse the repository at this point in the history