Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DebugStack#queries docblock type #3812

Merged
merged 1 commit into from
Jan 5, 2020
Merged

Fix DebugStack#queries docblock type #3812

merged 1 commit into from
Jan 5, 2020

Conversation

ostrolucky
Copy link
Member

Q A
Type bug
BC Break no
Fixed issues

@morozov
Copy link
Member

morozov commented Jan 5, 2020 •
edited
Loading

On an unrelated note, this is a case where I share the @beberlei's sentiment about our CI being too hard to deal with. But it's not because of CI but because some of our types expressed via arrays of arrays of arrays are hard to comprehend. In this specific case, we could easily use an array of objects that represent a stack frame and have their properties explicitly defined. This would be beneficial from type safety, type simplicity and memory footprint (1, 2).

@ostrolucky ostrolucky force-pushed the fix-debugstack-queries-docblock branch from a97cc05 to 77a394d Compare January 5, 2020 17:16
@ostrolucky ostrolucky merged commit d49d68f into doctrine:2.10 Jan 5, 2020
@ostrolucky ostrolucky deleted the fix-debugstack-queries-docblock branch January 5, 2020 17:55
@morozov morozov added this to the 2.10.2 milestone Jan 5, 2020
@doctrinebot doctrinebot mentioned this pull request Apr 20, 2020
Merged
rgrellmann added a commit to Rossmann-IT/dbal that referenced this pull request Apr 22, 2020
@rgrellmann
Merge tag '2.10.2' into oracle122
1a8890a 
Release [2.10.2](https://github.com/doctrine/dbal/milestone/75)

2.10.2
======

- Total issues resolved: **4**
- Total pull requests resolved: **19**
- Total contributors: **10**

Improvement,Static Analysis
---------------------------

 - [3964: Mark every exception as immutable](doctrine#3964) thanks to @greg0ire

CI,Improvement,Static Analysis
------------------------------

 - [3961: Stop relying on the master version of Psalm](doctrine#3961) thanks to @greg0ire
 - [3951: Setup static analysis with Psalm](doctrine#3951) thanks to @greg0ire
 - [3799: Upgrade to PHPStan v0.12](doctrine#3799) thanks to @lcobucci

Improvement,Logging,Test Suite
------------------------------

 - [3957: Reworked LoggingTest to be able to test Statement::executeUpdate()](doctrine#3957) thanks to @morozov

CI,Code Style,Improvement,Strict Typing
---------------------------------------

 - [3955: Remove baseline](doctrine#3955) thanks to @greg0ire

Bug,SQLite,Schema Introspection,Schema Managers
-----------------------------------------------

 - [3937: Column comment incorrectly introspected on SQLite](doctrine#3937) thanks to @morozov

Bug,Documentation,Prepared Statements,Query
-------------------------------------------

 - [3896: Updated documentation for QueryBuilder::execute() return value type](doctrine#3896) thanks to @morozov

Bug,Prepared Statements
-----------------------

 - [3894: Make sure that the $types array has the same keys $params](doctrine#3894) thanks to @morozov
 - [3893: Ensure the constructor arguments are passed to custom classes](doctrine#3893) thanks to @duncan3dc
 - [3843: Fix unquoted stmt fragments backslash escaping](doctrine#3843) thanks to @morozov

Documentation,Improvement
-------------------------

 - [3886: Update readme](doctrine#3886) thanks to @greg0ire
 - [3834: Fix docblock typos in DriverManager docs](doctrine#3834) thanks to @CHItA

CI,Improvement,MariaDB,MySQL
----------------------------

 - [3884: Use Docker consistently](doctrine#3884) thanks to @greg0ire
 - [3478: Improve readiness probe stability for containerized databases on CI](doctrine#3478) thanks to @morozov

 - [3883: Fix broken build](doctrine#3883) thanks to @greg0ire

Bug,Documentation,Query,Query Limit/Offset Modification
-------------------------------------------------------

 - [3842: Fixed the QueryBuilder::setMaxResults() signature to accept NULL](doctrine#3842) thanks to @morozov

Bug,Query
---------

 - [3832: Fix JOIN with no condition bug](doctrine#3832) thanks to @BenMorel

Bug,PostgreSQL,Schema Introspection
-----------------------------------

 - [3821: &doctrine#91;pg&doctrine#93; fix getting table information if search&doctrine#95;path contains escaped schema name](doctrine#3821) thanks to @linniksa

Documentation,Improvement,Logging
---------------------------------

 - [3812: Fix DebugStack#queries docblock type](doctrine#3812) thanks to @ostrolucky

Bug,Regression,Schema
---------------------

 - [3790: fixed unqualified table name of fk constraints when using schemas](doctrine#3790) thanks to @stlrnz and @Alarich

# gpg: Signature made Mon Apr 20 19:59:36 2020
# gpg:                using DSA key 2C3A645671828132
# gpg: Can't check signature: public key not found

# Conflicts:
#	README.md
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@morozov morozov morozov approved these changes

Assignees

@ostrolucky ostrolucky

Labels
Documentation Improvement Logging
Projects
None yet
Milestone
2.10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ostrolucky @morozov @greg0ire