Deprecate calling QueryBuilder methods with an array argument

UPGRADE.md

@@ -9,6 +9,10 @@ The usage of the `andX()` and `orX()` methods of the `ExpressionBuilder` class h
 The usage of the `add()` and `addMultiple()` methods of the `CompositeExpression` class has been deprecated. Use `with()` instead, which returns a new instance.
 In the future, the `add*()` methods will be removed and the class will be effectively immutable.
 
+## Deprecated calling `QueryBuilder` methods with an array argument
+
+Calling the `select()`, `addSelect()`, `groupBy()` and `addGroupBy()` methods with an array argument is deprecated.
+
 # Upgrade to 2.10
 
 ## Deprecated `Doctrine\DBAL\Event\ConnectionEventArgs` methods

lib/Doctrine/DBAL/Query/QueryBuilder.php

@@ -451,18 +451,21 @@ public function add($sqlPartName, $sqlPart, $append = false)
  * Specifies an item that is to be returned in the query result.
  * Replaces any previously specified selections, if any.
  *
+ * USING AN ARRAY ARGUMENT IS DEPRECATED. Pass each value as an individual argument.
+ *
  * <code>
  * $qb = $conn->createQueryBuilder()
  * ->select('u.id', 'p.id')
  * ->from('users', 'u')
  * ->leftJoin('u', 'phonenumbers', 'p', 'u.id = p.user_id');
  * </code>
  *
- * @param mixed $select The selection expressions.
+ * @param string|string[]|null $select The selection expression. USING AN ARRAY OR NULL IS DEPRECATED.
+ * Pass each value as an individual argument.
  *
  * @return $this This QueryBuilder instance.
  */
- public function select($select = null)
+ public function select($select = null/*, string ...$selects*/)
  {
  $this->type = self::SELECT;
 
@@ -497,6 +500,8 @@ public function distinct() : self
  /**
  * Adds an item that is to be returned in the query result.
  *
+ * USING AN ARRAY ARGUMENT IS DEPRECATED. Pass each value as an individual argument.
+ *
  * <code>
  * $qb = $conn->createQueryBuilder()
  * ->select('u.id')
@@ -505,11 +510,12 @@ public function distinct() : self
  * ->leftJoin('u', 'phonenumbers', 'u.id = p.user_id');
  * </code>
  *
- * @param mixed $select The selection expression.
+ * @param string|string[]|null $select The selection expression. USING AN ARRAY OR NULL IS DEPRECATED.
+ * Pass each value as an individual argument.
  *
  * @return $this This QueryBuilder instance.
  */
- public function addSelect($select = null)
+ public function addSelect($select = null/*, string ...$selects*/)
  {
  $this->type = self::SELECT;
 
@@ -869,18 +875,21 @@ public function orWhere($where)
  * Specifies a grouping over the results of the query.
  * Replaces any previously specified groupings, if any.
  *
+ * USING AN ARRAY ARGUMENT IS DEPRECATED. Pass each value as an individual argument.
+ *
  * <code>
  * $qb = $conn->createQueryBuilder()
  * ->select('u.name')
  * ->from('users', 'u')
  * ->groupBy('u.id');
  * </code>
  *
- * @param mixed $groupBy The grouping expression.
+ * @param string|string[] $groupBy The grouping expression. USING AN ARRAY IS DEPRECATED.
+ * Pass each value as an individual argument.
  *
  * @return $this This QueryBuilder instance.
  */
- public function groupBy($groupBy)
+ public function groupBy($groupBy/*, string ...$groupBys*/)
  {
  if (empty($groupBy)) {
  return $this;
@@ -894,6 +903,8 @@ public function groupBy($groupBy)
  /**
  * Adds a grouping expression to the query.
  *
+ * USING AN ARRAY ARGUMENT IS DEPRECATED. Pass each value as an individual argument.
+ *
  * <code>
  * $qb = $conn->createQueryBuilder()
  * ->select('u.name')
@@ -902,11 +913,12 @@ public function groupBy($groupBy)
  * ->addGroupBy('u.createdAt');
  * </code>
  *
- * @param mixed $groupBy The grouping expression.
+ * @param string|string[] $groupBy The grouping expression. USING AN ARRAY IS DEPRECATED.
+ * Pass each value as an individual argument.
  *
  * @return $this This QueryBuilder instance.
  */
- public function addGroupBy($groupBy)
+ public function addGroupBy($groupBy/*, string ...$groupBys*/)
  {
  if (empty($groupBy)) {
  return $this;