Made some platform class names reflect the lowest server version they support #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
versioned-platform-classes
branch
from
6db1268
to
9d6d4cc
Compare
greg0ire
reviewed
Mar 20, 2020
… support The `PostgreSqlPlatform`, `SQLAnywherePlatform` and `SQLServerPlatform` classes have been renamed to `PostgreSQL94Platform`, `SQLAnywhere16Platform` and `SQLServer2012Platform` respectively. When deprecating an old platform version, we can deprecate and later remove a specific class. Otherwise, there's no way to express the deprecation on the class level and the upgrade notes contain sentences like: "`XYZPlatform` and `XYZKeywords` now represent XYZ (version)".
morozov
force-pushed
the
versioned-platform-classes
branch
from
9d6d4cc
to
bd87aa6
Compare
greg0ire
approved these changes
Mar 20, 2020
|
Thanks @morozov ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PostgreSqlPlatform,SQLAnywherePlatformandSQLServerPlatformclasses have been renamed toPostgreSQL94Platform,SQLAnywhere16PlatformandSQLServer2012Platformrespectively.This way, when deprecating an old platform version, we can deprecate and later remove a specific class. Otherwise, there's no way to express the deprecation on the class level and the upgrade notes contain sentences like: "
XYZPlatformandXYZKeywordsnow represent XYZ (version)".I deliberately didn't rename
MySqlPlatformsince there's no clear understanding of which MySQL version it corresponds to. We can remove it when we drop the support for MySQL 5.6.Additionally, some leftovers of the platform and keyword class are removed (somehow they survived the backport in #3906).
† Despite the fact that the class names are being changed, such classes exist in
2.xand have the same API and purpose.