Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Savepoints #4

Merged
12 commits merged into from
Oct 1, 2010
Merged

Savepoints #4

12 commits merged into from
Oct 1, 2010

Conversation

lsmith77
Copy link
Member

initial version ..
a couple of questions:

  • how to handle the savepointFormat config option?
  • should the [create|release|rollback]Savepoint() methods check if they are supported?
  • obviously since with savepoints we can actually do proper partial rollbacks, i am not setting the $this->_isRollbackOnly = true;
  • don't really like the changes i had to do to the test suite

also of course there needs to be more tests, not only for the new savepoint setting, but also for [create|release|rollback]Savepoint()

@lsmith77
Copy link
Member Author

lsmith77 commented Oct 1, 2010

main issue remaining is DB2 being stupid

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant