Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations for ConnectionHelper #4059

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

dmaicher
Copy link
Contributor

@dmaicher dmaicher commented Jun 9, 2020

Q A
Type improvement
BC Break yes
Fixed issues -

Summary

See #3956

Cleanup for the deprecated ConnectionHelper

@dmaicher dmaicher force-pushed the cleanup_deprecations branch from e3f9b18 to 905f0a0 Compare June 9, 2020 12:06
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2020

Codecov Report

Merging #4059 into 3.0.x will increase coverage by 0.10%.
The diff coverage is 20.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              3.0.x    #4059      +/-   ##
============================================
+ Coverage     78.09%   78.19%   +0.10%     
+ Complexity     4603     4588      -15     
============================================
  Files           189      188       -1     
  Lines         11552    11527      -25     
============================================
- Hits           9021     9014       -7     
+ Misses         2531     2513      -18     
Impacted Files Coverage Δ Complexity Δ
src/Tools/Console/Command/ReservedWordsCommand.php 0.00% <0.00%> (ø) 12.00 <1.00> (-4.00)
src/Tools/Console/ConsoleRunner.php 0.00% <0.00%> (-11.12%) 3.00 <2.00> (-4.00)
src/Tools/Console/Command/RunSqlCommand.php 97.29% <100.00%> (+8.66%) 10.00 <1.00> (-4.00) ⬆️
...le/ConnectionProvider/SingleConnectionProvider.php 60.00% <0.00%> (+60.00%) 4.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3710903...905f0a0. Read the comment docs.

@morozov morozov merged commit be5e93e into doctrine:3.0.x Jun 10, 2020
@morozov morozov added this to the 3.0.0 milestone Jun 10, 2020
@morozov morozov self-assigned this Jun 10, 2020
@morozov
Copy link
Member

morozov commented Jun 10, 2020

Thanks, @dmaicher.

@dmaicher dmaicher deleted the cleanup_deprecations branch June 10, 2020 19:39
@morozov morozov changed the title remove deprecations for ConnectionHelper Remove deprecations for ConnectionHelper Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants