Remove slash from const name in transactions documentation #4204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Aug 8, 2020
greeflas
force-pushed
the
fix-transactions-doc
branch
from
a989a15 to
ab2993d
Compare
|
Both Travis and AppVeyor look like they still run with the configuration for branch master, which I would understand if you hadn't rebased properly, but you very much did. Maybe it did not pick up on the fact that you retargeted? Let's close and reopen. |
greg0ire
previously approved these changes
Aug 8, 2020
SenseException
requested changes
Aug 9, 2020
docs/en/reference/transactions.rst
Outdated
| @@ -258,4 +258,3 @@ If you need stricter control, you can catch the concrete exceptions directly: | |||
| - ``Doctrine\DBAL\Exception\LockWaitTimeoutException``: this exception happens when | |||
| a transaction has to wait a considerable amount of time to obtain a lock, even if | |||
| a deadlock is not involved. | |||
|
|
|||
There was a problem hiding this comment.
Please don't remove the last new line at the end of the file.
greeflas
force-pushed
the
fix-transactions-doc
branch
from
ab2993d to
65ca7ae
Compare
greg0ire
approved these changes
Aug 10, 2020
SenseException
approved these changes
Aug 10, 2020
|
Thank you @greeflas. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi!
I have just removed slash from const name to make it look better.