Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Synchronizer package #4217

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Remove the Synchronizer package #4217

merged 1 commit into from
Aug 20, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented Aug 20, 2020

Q A
Type improvement
BC Break yes

The package is deprecated in #4213.

@morozov morozov added this to the 3.0.0 milestone Aug 20, 2020
@morozov morozov requested a review from greg0ire August 20, 2020 06:32
greg0ire
greg0ire reviewed Aug 20, 2020
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we take the same approach as for sharding: don't make any documentation changes during the deprecation (#3905) and removed the documentation during the code removal (#3906).

No docs to remove?

@morozov
Copy link
Member Author

morozov commented Aug 20, 2020

Apparently, it's already removed in #3906.

@morozov morozov merged commit 66c17e2 into doctrine:3.0.x Aug 20, 2020
@morozov morozov deleted the remove-schema-synchronizer branch August 20, 2020 17:37
@morozov morozov self-assigned this Aug 20, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees

@morozov morozov

Labels
BC Break Schema
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @greg0ire